From a4fe0fb809867762be4ea364ec7cb410ca9d8744 Mon Sep 17 00:00:00 2001 From: khushi8112 Date: Sat, 11 Oct 2025 11:23:56 +0530 Subject: [PATCH] refactor: use query builder to set company address --- .../doctype/sales_invoice/sales_invoice.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py index 120d27d2cd4..8608cea9d21 100644 --- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py +++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py @@ -2885,14 +2885,16 @@ def save_company_master_details(name, company, details): if company_address: company_address_display = frappe.db.get_value("Sales Invoice", name, "company_address_display") if not company_address_display or details.get("address_line1"): - frappe.db.set_value( - "Sales Invoice", - name, - { - "company_address": company_address, - "company_address_display": get_address_display(company_address), - }, - ) + from frappe.query_builder import DocType + + SalesInvoice = DocType("Sales Invoice") + + ( + frappe.qb.update(SalesInvoice) + .set(SalesInvoice.company_address, company_address) + .set(SalesInvoice.company_address_display, get_address_display(company_address)) + .where(SalesInvoice.name == name) + ).run() return True