nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-15 01:43:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: UOM whole number check truncated instead of rounding

Browse Source 
cint truncates, so a stock_qty of 1999.9998 (dust from qty times
conversion factor) compared as abs(1999 - 2000.0) > epsilon and was
rejected as fractional even though it rounds to a whole number at
field precision, with the error confusingly printing the rounded
value: 'Quantity (2000.0) cannot be a fraction'. Round to field
precision first, then require the result to be a whole number.
Dust above an integer already passed; this fixes the asymmetry for
dust below.
This commit is contained in:
Mihir Kandoi
2026-08-07 13:04:45 +05:30
parent a219f890df
commit a464a6e4a1
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/utilities/transaction_base.py
View File

@@ -618,13 +618,13 @@ def validate_uom_is_integer(doc, uom_field, qty_fields, child_dt=None):
for f in qty_fields: for f in qty_fields:
qty = d.get(f) qty = d.get(f)
if qty: if qty:
precision = d.precision(f) qty = flt(qty, d.precision(f))
if abs(cint(qty) - flt(qty, precision)) > 0.0000001: if qty != cint(qty):
frappe.throw( frappe.throw(
_( _(
"Row {1}: Quantity ({0}) cannot be a fraction. To allow this, disable '{2}' in UOM {3}." "Row {1}: Quantity ({0}) cannot be a fraction. To allow this, disable '{2}' in UOM {3}."
).format( ).format(
flt(qty, precision), qty,
d.idx, d.idx,
frappe.bold(_("Must be Whole Number")), frappe.bold(_("Must be Whole Number")),
frappe.bold(d.get(uom_field)), frappe.bold(d.get(uom_field)),