nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-07 23:22:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Use db.set_single_value (#35668)

Browse Source 
I just applied semgrep autofix. Untested completed, review before merging.

```yaml
- id: frappe-set-value-semantics
  patterns:
    - pattern-either:
      - pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
      - pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
  fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
  message: |
    If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
  languages: [python]
  severity: ERROR
```
This commit is contained in:
Ankush Menat
2023-06-13 17:30:38 +05:30
committed by GitHub
parent b43e068852
commit a3ea985348
43 changed files with 124 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/patches/v12_0/rename_tolerance_fields.py
View File

@@ -11,6 +11,6 @@ def execute():
rename_field("Item", "tolerance", "over_delivery_receipt_allowance")
qty_allowance = frappe.db.get_single_value("Stock Settings", "over_delivery_receipt_allowance")
frappe.db.set_value("Accounts Settings", None, "over_delivery_receipt_allowance", qty_allowance)
frappe.db.set_single_value("Accounts Settings", "over_delivery_receipt_allowance", qty_allowance)
frappe.db.sql("update tabItem set over_billing_allowance=over_delivery_receipt_allowance")

4
erpnext/patches/v12_0/set_automatically_process_deferred_accounting_in_accounts_settings.py
View File

@@ -4,6 +4,6 @@ import frappe
def execute():
frappe.reload_doc("accounts", "doctype", "accounts_settings")
frappe.db.set_value(
"Accounts Settings", None, "automatically_process_deferred_accounting_entry", 1
frappe.db.set_single_value(
"Accounts Settings", "automatically_process_deferred_accounting_entry", 1
)

2
erpnext/patches/v12_0/set_default_homepage_type.py
View File

@@ -2,4 +2,4 @@ import frappe
def execute():
frappe.db.set_value("Homepage", "Homepage", "hero_section_based_on", "Default")
frappe.db.set_single_value("Homepage", "hero_section_based_on", "Default")

2
erpnext/patches/v12_0/set_priority_for_support.py
View File

@@ -46,7 +46,7 @@ def set_priorities_service_level():
frappe.reload_doc("support", "doctype", "service_level")
frappe.reload_doc("support", "doctype", "support_settings")
frappe.db.set_value("Support Settings", None, "track_service_level_agreement", 1)
frappe.db.set_single_value("Support Settings", "track_service_level_agreement", 1)
for service_level in service_level_priorities:
if service_level: