Merge pull request #43863 from frappe/mergify/bp/version-14-hotfix/pr-43685

fix: do not check for payment terms details for return invoices. (backport #43685)
This commit is contained in:
ruthra kumar
2024-10-28 15:53:06 +05:30
committed by GitHub
6 changed files with 23 additions and 8 deletions

View File

@@ -415,6 +415,11 @@ class AccountsController(TransactionBase):
)
def validate_invoice_documents_schedule(self):
if self.is_return:
self.payment_terms_template = ""
self.payment_schedule = []
return
self.validate_payment_schedule_dates()
self.set_due_date()
self.set_payment_schedule()
@@ -429,7 +434,7 @@ class AccountsController(TransactionBase):
self.validate_payment_schedule_amount()
def validate_all_documents_schedule(self):
if self.doctype in ("Sales Invoice", "Purchase Invoice") and not self.is_return:
if self.doctype in ("Sales Invoice", "Purchase Invoice"):
self.validate_invoice_documents_schedule()
elif self.doctype in ("Quotation", "Purchase Order", "Sales Order"):
self.validate_non_invoice_documents_schedule()