nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-15 23:48:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: clear stray permission message when item dashboard has no warehouse access

Browse Source 
(cherry picked from commit 8c7b2f4d3c)
This commit is contained in:
pandiyan
2026-07-03 18:25:01 +05:30
committed by Mergify
parent 3c1f163e3b
commit a39753ee08
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/stock/dashboard/item_dashboard.py
View File

@@ -12,6 +12,9 @@ def get_data(
item_code=None, warehouse=None, item_group=None, start=0, sort_by="actual_qty", sort_order="desc" item_code=None, warehouse=None, item_group=None, start=0, sort_by="actual_qty", sort_order="desc"
): ):
"""Return data to render the item dashboard""" """Return data to render the item dashboard"""
if not frappe.has_permission("Bin", "read"):
return []
filters = [] filters = []
if item_code: if item_code:
filters.append(["item_code", "=", item_code]) filters.append(["item_code", "=", item_code])
@@ -33,7 +36,10 @@ def get_data(
if build_match_conditions("Warehouse", user=frappe.session.user): if build_match_conditions("Warehouse", user=frappe.session.user):
filters.append(["warehouse", "in", [w.name for w in frappe.get_list("Warehouse")]]) filters.append(["warehouse", "in", [w.name for w in frappe.get_list("Warehouse")]])
except frappe.PermissionError: except frappe.PermissionError:
# user does not have access on warehouse # user does not have access on warehouse; build_match_conditions already queued a
# "Not permitted" message via frappe.throw before this was caught, drop it so the
# client doesn't show a spurious error for a request that's failing gracefully here
frappe.clear_last_message()
return [] return []
items = frappe.db.get_all( items = frappe.db.get_all(