From a3444a07b7f597f57b89ed2119be2a9da5273e2a Mon Sep 17 00:00:00 2001 From: "Nihantra C. Patel" <141945075+Nihantra-Patel@users.noreply.github.com> Date: Mon, 3 Jun 2024 17:26:14 +0530 Subject: [PATCH] fix: completed DC will not appear in a delivery trip (#41655) * fix: completed DC will not appear in a delivery trip * fix: completed DC will not appear in a delivery trip (cherry picked from commit 4f0214d00e6aab808597c7ce766b1de9ff8b2ec7) # Conflicts: # erpnext/stock/doctype/delivery_note/delivery_note.js --- erpnext/stock/doctype/delivery_note/delivery_note.js | 4 ++++ erpnext/stock/doctype/delivery_trip/delivery_trip.js | 2 ++ 2 files changed, 6 insertions(+) diff --git a/erpnext/stock/doctype/delivery_note/delivery_note.js b/erpnext/stock/doctype/delivery_note/delivery_note.js index 23d0adc5708..d564386016c 100644 --- a/erpnext/stock/doctype/delivery_note/delivery_note.js +++ b/erpnext/stock/doctype/delivery_note/delivery_note.js @@ -205,7 +205,11 @@ erpnext.stock.DeliveryNoteController = class DeliveryNoteController extends ( ); } +<<<<<<< HEAD if (doc.docstatus == 1) { +======= + if (doc.docstatus == 1 && doc.status != "Completed" && frappe.model.can_create("Delivery Trip")) { +>>>>>>> 4f0214d00e (fix: completed DC will not appear in a delivery trip (#41655)) this.frm.add_custom_button( __("Delivery Trip"), function () { diff --git a/erpnext/stock/doctype/delivery_trip/delivery_trip.js b/erpnext/stock/doctype/delivery_trip/delivery_trip.js index 4f8649c0bfa..2445d1f66ea 100755 --- a/erpnext/stock/doctype/delivery_trip/delivery_trip.js +++ b/erpnext/stock/doctype/delivery_trip/delivery_trip.js @@ -58,10 +58,12 @@ frappe.ui.form.on("Delivery Trip", { date_field: "posting_date", setters: { company: frm.doc.company, + customer: null, }, get_query_filters: { docstatus: 1, company: frm.doc.company, + status: ["Not In", ["Completed", "Cancelled"]], }, }); },