Merge pull request #57728 from frappe/mergify/bp/version-16-hotfix/pr-57725

fix(stock): scope over deliver/receive role check to delivery and receipt overflow (backport #57725)
This commit is contained in:
Mihir Kandoi
2026-08-03 13:13:22 +05:30
committed by GitHub
5 changed files with 62 additions and 12 deletions

View File

@@ -445,11 +445,12 @@ class StatusUpdater(Document):
else (0, {}, None, None)
)
role_allowed_to_over_deliver_receive = frappe.get_single_value(
"Stock Settings", "role_allowed_to_over_deliver_receive"
)
role_allowed_to_over_bill = frappe.get_single_value("Accounts Settings", "role_allowed_to_over_bill")
role = role_allowed_to_over_deliver_receive if qty_or_amount == "qty" else role_allowed_to_over_bill
role = None
if qty_or_amount == "qty":
if args.get("overflow_type") in ("delivery", "receipt"):
role = frappe.get_single_value("Stock Settings", "role_allowed_to_over_deliver_receive")
else:
role = frappe.get_single_value("Accounts Settings", "role_allowed_to_over_bill")
overflow_percent = (
(item[args["target_field"]] - item[args["target_ref_field"]]) / item[args["target_ref_field"]]