From a208c5681317458351c683f416d22abd985d404d Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Mon, 3 Aug 2015 13:18:54 +0530 Subject: [PATCH] [enhancement] auto insert item price if missing, #3533 --- .../current/auto_insert_price_list_rate.md | 1 + erpnext/change_log/current/product_bundle.md | 1 + erpnext/patches.txt | 2 +- erpnext/public/js/controllers/transaction.js | 16 +- .../doctype/sales_order/test_sales_order.py | 33 +++ .../selling_settings/selling_settings.json | 171 +++++++++++- .../setup/page/setup_wizard/setup_wizard.py | 1 + .../stock_settings/stock_settings.json | 252 ++++++++++++++++-- erpnext/stock/get_item_details.py | 18 ++ 9 files changed, 458 insertions(+), 37 deletions(-) create mode 100644 erpnext/change_log/current/auto_insert_price_list_rate.md create mode 100644 erpnext/change_log/current/product_bundle.md diff --git a/erpnext/change_log/current/auto_insert_price_list_rate.md b/erpnext/change_log/current/auto_insert_price_list_rate.md new file mode 100644 index 00000000000..6ea6689a6bb --- /dev/null +++ b/erpnext/change_log/current/auto_insert_price_list_rate.md @@ -0,0 +1 @@ +- Automatically insert Price List Rate in Price List if added in transaction if permission exists and allowed from Stock Settings diff --git a/erpnext/change_log/current/product_bundle.md b/erpnext/change_log/current/product_bundle.md new file mode 100644 index 00000000000..56c1716d89f --- /dev/null +++ b/erpnext/change_log/current/product_bundle.md @@ -0,0 +1 @@ +- Product Bundle now allowed for all Items (stock or non-stock) diff --git a/erpnext/patches.txt b/erpnext/patches.txt index 761f1a94b36..b2d8068eeaf 100644 --- a/erpnext/patches.txt +++ b/erpnext/patches.txt @@ -187,4 +187,4 @@ execute:frappe.db.sql("update `tabLeave Type` set include_holiday=0") erpnext.patches.v5_4.set_root_and_report_type erpnext.patches.v5_4.notify_system_managers_regarding_wrong_tax_calculation erpnext.patches.v5_4.fix_invoice_outstanding -execute:frappe.db.sql("update `tabStock Ledger Entry` set stock_queue = '[]' where voucher_type = 'Stock Reconciliation' and ifnull(qty_after_transaction, 0) = 0") \ No newline at end of file +execute:frappe.db.sql("update `tabStock Ledger Entry` set stock_queue = '[]' where voucher_type = 'Stock Reconciliation' and ifnull(qty_after_transaction, 0) = 0") diff --git a/erpnext/public/js/controllers/transaction.js b/erpnext/public/js/controllers/transaction.js index 5ba3651fc6f..ba10702bd98 100644 --- a/erpnext/public/js/controllers/transaction.js +++ b/erpnext/public/js/controllers/transaction.js @@ -36,7 +36,7 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ if(this.frm.fields_dict["items"]) { this["items_remove"] = this.calculate_taxes_and_totals; } - + if(this.frm.fields_dict["recurring_print_format"]) { this.frm.set_query("recurring_print_format", function(doc) { return{ @@ -46,7 +46,7 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } }); } - + if(this.frm.fields_dict["return_against"]) { this.frm.set_query("return_against", function(doc) { var filters = { @@ -56,13 +56,13 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ }; if (me.frm.fields_dict["customer"] && doc.customer) filters["customer"] = doc.customer; if (me.frm.fields_dict["supplier"] && doc.supplier) filters["supplier"] = doc.supplier; - + return { filters: filters } }); } - + }, onload_post_render: function() { @@ -275,7 +275,7 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ posting_date: function() { var me = this; if (this.frm.doc.posting_date) { - if ((this.frm.doc.doctype == "Sales Invoice" && this.frm.doc.customer) || + if ((this.frm.doc.doctype == "Sales Invoice" && this.frm.doc.customer) || (this.frm.doc.doctype == "Purchase Invoice" && this.frm.doc.supplier)) { return frappe.call({ method: "erpnext.accounts.party.get_due_date", @@ -284,7 +284,7 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ "party_type": me.frm.doc.doctype == "Sales Invoice" ? "Customer" : "Supplier", "party": me.frm.doc.doctype == "Sales Invoice" ? me.frm.doc.customer : me.frm.doc.supplier, "company": me.frm.doc.company - }, + }, callback: function(r, rt) { if(r.message) { me.frm.set_value("due_date", r.message); @@ -301,7 +301,7 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ get_company_currency: function() { return erpnext.get_currency(this.frm.doc.company); }, - + contact_person: function() { erpnext.utils.get_contact_details(this.frm); }, @@ -373,7 +373,7 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ plc_conversion_rate: function() { if(this.frm.doc.price_list_currency === this.get_company_currency()) { this.frm.set_value("plc_conversion_rate", 1.0); - } else if(this.frm.doc.price_list_currency === this.frm.doc.currency + } else if(this.frm.doc.price_list_currency === this.frm.doc.currency && this.frm.doc.plc_conversion_rate && cint(this.frm.doc.plc_conversion_rate) != 1 && cint(this.frm.doc.plc_conversion_rate) != cint(this.frm.doc.conversion_rate)) { this.frm.set_value("conversion_rate", this.frm.doc.plc_conversion_rate); diff --git a/erpnext/selling/doctype/sales_order/test_sales_order.py b/erpnext/selling/doctype/sales_order/test_sales_order.py index d4d5f92b595..1ceda1246ef 100644 --- a/erpnext/selling/doctype/sales_order/test_sales_order.py +++ b/erpnext/selling/doctype/sales_order/test_sales_order.py @@ -240,6 +240,37 @@ class TestSalesOrder(unittest.TestCase): self.assertTrue("_Test Service Product Bundle Item 1" in [d.item_code for d in so.packed_items]) self.assertTrue("_Test Service Product Bundle Item 2" in [d.item_code for d in so.packed_items]) + def test_auto_insert_price(self): + from erpnext.stock.doctype.item.test_item import make_item + make_item("_Test Item for Auto Price List", {"is_stock_item": 0, "is_sales_item": 1}) + frappe.db.set_value("Stock Settings", None, "auto_insert_price_list_rate_if_missing", 1) + + item_price = frappe.db.get_value("Item Price", {"price_list": "_Test Price List", + "item_code": "_Test Item for Auto Price List"}) + if item_price: + frappe.delete_doc("Item Price", item_price) + + make_sales_order(item_code = "_Test Item for Auto Price List", selling_price_list="_Test Price List", rate=100) + + self.assertEquals(frappe.db.get_value("Item Price", + {"price_list": "_Test Price List", "item_code": "_Test Item for Auto Price List"}, "price_list_rate"), 100) + + + # do not update price list + frappe.db.set_value("Stock Settings", None, "auto_insert_price_list_rate_if_missing", 0) + + item_price = frappe.db.get_value("Item Price", {"price_list": "_Test Price List", + "item_code": "_Test Item for Auto Price List"}) + if item_price: + frappe.delete_doc("Item Price", item_price) + + make_sales_order(item_code = "_Test Item for Auto Price List", selling_price_list="_Test Price List", rate=100) + + self.assertEquals(frappe.db.get_value("Item Price", + {"price_list": "_Test Price List", "item_code": "_Test Item for Auto Price List"}, "price_list_rate"), None) + + frappe.db.set_value("Stock Settings", None, "auto_insert_price_list_rate_if_missing", 1) + def make_sales_order(**args): so = frappe.new_doc("Sales Order") args = frappe._dict(args) @@ -250,6 +281,8 @@ def make_sales_order(**args): so.customer = args.customer or "_Test Customer" so.delivery_date = add_days(so.transaction_date, 10) so.currency = args.currency or "INR" + if args.selling_price_list: + so.selling_price_list = args.selling_price_list so.append("items", { "item_code": args.item or args.item_code or "_Test Item", diff --git a/erpnext/selling/doctype/selling_settings/selling_settings.json b/erpnext/selling/doctype/selling_settings/selling_settings.json index aafc31e3133..fb239d61ff0 100644 --- a/erpnext/selling/doctype/selling_settings/selling_settings.json +++ b/erpnext/selling/doctype/selling_settings/selling_settings.json @@ -1,103 +1,250 @@ { + "allow_copy": 0, + "allow_import": 0, + "allow_rename": 0, "creation": "2013-06-25 10:25:16", + "custom": 0, "description": "Settings for Selling Module", "docstatus": 0, "doctype": "DocType", "document_type": "Other", "fields": [ { + "allow_on_submit": 0, "default": "Customer Name", "fieldname": "cust_master_name", "fieldtype": "Select", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, "in_list_view": 1, "label": "Customer Naming By", + "no_copy": 0, "options": "Customer Name\nNaming Series", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "campaign_naming_by", "fieldtype": "Select", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, "in_list_view": 1, "label": "Campaign Naming By", + "no_copy": 0, "options": "Campaign Name\nNaming Series", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "description": "", "fieldname": "customer_group", "fieldtype": "Link", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, "in_list_view": 1, "label": "Default Customer Group", + "no_copy": 0, "options": "Customer Group", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "description": "", "fieldname": "territory", "fieldtype": "Link", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, "in_list_view": 1, "label": "Default Territory", + "no_copy": 0, "options": "Territory", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "selling_price_list", "fieldtype": "Link", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, "in_list_view": 1, "label": "Default Price List", + "no_copy": 0, "options": "Price List", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "column_break_5", "fieldtype": "Column Break", - "permlevel": 0 + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "so_required", "fieldtype": "Select", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Sales Order Required", + "no_copy": 0, "options": "No\nYes", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "dn_required", "fieldtype": "Select", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Delivery Note Required", + "no_copy": 0, "options": "No\nYes", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "maintain_same_sales_rate", "fieldtype": "Check", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Maintain Same Rate Throughout Sales Cycle", - "permlevel": 0 + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "editable_price_list_rate", "fieldtype": "Check", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Allow user to edit Price List Rate in transactions", - "permlevel": 0 + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 } ], + "hide_heading": 0, + "hide_toolbar": 0, "icon": "icon-cog", "idx": 1, + "in_create": 0, + "in_dialog": 0, + "is_submittable": 0, "issingle": 1, - "modified": "2015-02-05 05:11:46.384538", + "istable": 0, + "modified": "2015-08-03 12:59:51.829458", "modified_by": "Administrator", "module": "Selling", "name": "Selling Settings", "owner": "Administrator", "permissions": [ { + "amend": 0, + "apply_user_permissions": 0, + "cancel": 0, "create": 1, + "delete": 0, "email": 1, + "export": 0, + "if_owner": 0, + "import": 0, "permlevel": 0, "print": 1, "read": 1, + "report": 0, "role": "System Manager", + "set_user_permissions": 0, "share": 1, + "submit": 0, "write": 1 } - ] + ], + "read_only": 0, + "read_only_onload": 0 } \ No newline at end of file diff --git a/erpnext/setup/page/setup_wizard/setup_wizard.py b/erpnext/setup/page/setup_wizard/setup_wizard.py index 2734172978e..cb59a821d1a 100644 --- a/erpnext/setup/page/setup_wizard/setup_wizard.py +++ b/erpnext/setup/page/setup_wizard/setup_wizard.py @@ -220,6 +220,7 @@ def set_defaults(args): stock_settings.valuation_method = "FIFO" stock_settings.stock_uom = _("Nos") stock_settings.auto_indent = 1 + stock_settings.auto_insert_price_list_rate_if_missing = 1 stock_settings.save() selling_settings = frappe.get_doc("Selling Settings") diff --git a/erpnext/stock/doctype/stock_settings/stock_settings.json b/erpnext/stock/doctype/stock_settings/stock_settings.json index 4907e45c968..a6dc6d485dd 100644 --- a/erpnext/stock/doctype/stock_settings/stock_settings.json +++ b/erpnext/stock/doctype/stock_settings/stock_settings.json @@ -1,123 +1,343 @@ { + "allow_copy": 0, + "allow_import": 0, + "allow_rename": 0, "creation": "2013-06-24 16:37:54", + "custom": 0, "description": "Settings", "docstatus": 0, "doctype": "DocType", "fields": [ { + "allow_on_submit": 0, "default": "Item Code", "fieldname": "item_naming_by", "fieldtype": "Select", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, "in_list_view": 1, "label": "Item Naming By", + "no_copy": 0, "options": "Item Code\nNaming Series", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "description": "", "fieldname": "item_group", "fieldtype": "Link", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, "in_list_view": 1, "label": "Default Item Group", + "no_copy": 0, "options": "Item Group", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "stock_uom", "fieldtype": "Link", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, "in_list_view": 1, "label": "Default Stock UOM", + "no_copy": 0, "options": "UOM", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, + "fieldname": "auto_insert_price_list_rate_if_missing", + "fieldtype": "Check", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, + "label": "Auto insert Price List rate if missing", + "no_copy": 0, + "permlevel": 0, + "precision": "", + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 + }, + { + "allow_on_submit": 0, "fieldname": "column_break_4", "fieldtype": "Column Break", - "permlevel": 0 + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "valuation_method", "fieldtype": "Select", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Default Valuation Method", + "no_copy": 0, "options": "FIFO\nMoving Average", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "description": "Percentage you are allowed to receive or deliver more against the quantity ordered. For example: If you have ordered 100 units. and your Allowance is 10% then you are allowed to receive 110 units.", "fieldname": "tolerance", "fieldtype": "Float", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Allowance Percent", - "permlevel": 0 + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "allow_negative_stock", "fieldtype": "Check", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, "in_list_view": 1, "label": "Allow Negative Stock", - "permlevel": 0 + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "auto_material_request", "fieldtype": "Section Break", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Auto Material Request", - "permlevel": 0 + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "auto_indent", "fieldtype": "Check", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Raise Material Request when stock reaches re-order level", - "permlevel": 0 + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "reorder_email_notify", "fieldtype": "Check", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Notify by Email on creation of automatic Material Request", - "permlevel": 0 + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "freeze_stock_entries", "fieldtype": "Section Break", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Freeze Stock Entries", - "permlevel": 0 + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "stock_frozen_upto", "fieldtype": "Date", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Stock Frozen Upto", - "permlevel": 0 + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "stock_frozen_upto_days", "fieldtype": "Int", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Freeze Stocks Older Than [Days]", - "permlevel": 0 + "no_copy": 0, + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 }, { + "allow_on_submit": 0, "fieldname": "stock_auth_role", "fieldtype": "Link", + "hidden": 0, + "ignore_user_permissions": 0, + "in_filter": 0, + "in_list_view": 0, "label": "Role Allowed to edit frozen stock", + "no_copy": 0, "options": "Role", - "permlevel": 0 + "permlevel": 0, + "print_hide": 0, + "read_only": 0, + "report_hide": 0, + "reqd": 0, + "search_index": 0, + "set_only_once": 0, + "unique": 0 } ], + "hide_heading": 0, + "hide_toolbar": 0, "icon": "icon-cog", "idx": 1, + "in_create": 0, + "in_dialog": 0, + "is_submittable": 0, "issingle": 1, - "modified": "2015-07-13 05:28:23.839277", + "istable": 0, + "modified": "2015-08-03 13:00:36.082986", "modified_by": "Administrator", "module": "Stock", "name": "Stock Settings", "owner": "Administrator", "permissions": [ { + "amend": 0, + "apply_user_permissions": 0, + "cancel": 0, "create": 1, + "delete": 0, "email": 1, + "export": 0, + "if_owner": 0, + "import": 0, "permlevel": 0, "print": 1, "read": 1, + "report": 0, "role": "Stock Manager", + "set_user_permissions": 0, "share": 1, + "submit": 0, "write": 1 } - ] + ], + "read_only": 0, + "read_only_onload": 0 } \ No newline at end of file diff --git a/erpnext/stock/get_item_details.py b/erpnext/stock/get_item_details.py index faf3d98c0f8..c45439a90b3 100644 --- a/erpnext/stock/get_item_details.py +++ b/erpnext/stock/get_item_details.py @@ -214,6 +214,8 @@ def get_price_list_rate(args, item_doc, out): price_list_rate = get_price_list_rate_for(args, item_doc.variant_of) if not price_list_rate: + if args.price_list and args.rate: + insert_item_price(args) return {} out.price_list_rate = flt(price_list_rate) * flt(args.plc_conversion_rate) \ @@ -224,6 +226,22 @@ def get_price_list_rate(args, item_doc, out): out.update(get_last_purchase_details(item_doc.name, args.parent, args.conversion_rate)) +def insert_item_price(args): + """Insert Item Price if Price List and Price List Rate are specified and currency is the same""" + if frappe.db.get_value("Price List", args.price_list, "currency") == args.currency \ + and cint(frappe.db.get_single_value("Stock Settings", "auto_insert_price_list_rate_if_missing")): + if frappe.has_permission("Item Price", "write"): + item_price = frappe.get_doc({ + "doctype": "Item Price", + "price_list": args.price_list, + "item_code": args.item_code, + "currency": args.currency, + "price_list_rate": args.rate + }) + item_price.insert() + frappe.msgprint("Item Price added for {0} in Price List {1}".format(args.item_code, + args.price_list)) + def get_price_list_rate_for(args, item_code): return frappe.db.get_value("Item Price", {"price_list": args.price_list, "item_code": item_code}, "price_list_rate")