From a0a932a23520852ccf4ed2e8cd78b8a1627bc16e Mon Sep 17 00:00:00 2001 From: Nihantra Patel Date: Wed, 19 Jun 2024 16:09:44 +0530 Subject: [PATCH] refactor: item-wise purchase history (query to script report) --upd (cherry picked from commit 2851764ed6ba977a0327aa09c32be7a1db27c301) --- .../item_wise_purchase_history.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/erpnext/buying/report/item_wise_purchase_history/item_wise_purchase_history.py b/erpnext/buying/report/item_wise_purchase_history/item_wise_purchase_history.py index 27aec9c3abe..a8950af3ea3 100644 --- a/erpnext/buying/report/item_wise_purchase_history/item_wise_purchase_history.py +++ b/erpnext/buying/report/item_wise_purchase_history/item_wise_purchase_history.py @@ -229,8 +229,9 @@ def get_purchase_order_details(company_list, filters): .where(db_po.company.isin(tuple(company_list))) ) - if filters.get("item_group"): - query = query.where(db_po_item.item_group == filters.item_group) + for field in ("item_code", "item_group"): + if filters.get(field): + query = query.where(db_po_item[field] == filters[field]) if filters.get("from_date"): query = query.where(db_po.transaction_date >= filters.from_date) @@ -238,9 +239,6 @@ def get_purchase_order_details(company_list, filters): if filters.get("to_date"): query = query.where(db_po.transaction_date <= filters.to_date) - if filters.get("item_code"): - query = query.where(db_po_item.item_code == filters.item_code) - if filters.get("supplier"): query = query.where(db_po.supplier == filters.supplier)