nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-31 10:49:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Folio no validation

Browse Source
This commit is contained in:
Suraj Shetty
2020-05-03 19:10:02 +05:30
parent 268df35d80
commit 9fffe254fc
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/accounts/doctype/share_transfer/share_transfer.py
View File

@@ -168,10 +168,12 @@ class ShareTransfer(Document):
return 'Outside' return 'Outside'
def folio_no_validation(self): def folio_no_validation(self):
shareholders = ['from_shareholder', 'to_shareholder'] shareholder_fields = ['from_shareholder', 'to_shareholder']
shareholders = [shareholder for shareholder in shareholders if self.get(shareholder) is not ''] for shareholder_field in shareholder_fields:
for shareholder in shareholders: shareholder_name = self.get(shareholder_field)
doc = self.get_shareholder_doc(self.get(shareholder)) if not shareholder_name:
continue
doc = self.get_shareholder_doc(shareholder_name)
if doc.company != self.company: if doc.company != self.company:
frappe.throw(_('The shareholder does not belong to this company')) frappe.throw(_('The shareholder does not belong to this company'))
if not doc.folio_no: if not doc.folio_no: