nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-07 07:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #30455 from frappe/mergify/bp/version-13-hotfix/pr-30419

Browse Source 
fix: move item tax to item tax template patch (backport #30419)
This commit is contained in:
Saqib Ansari
2022-03-31 12:43:15 +05:30
committed by GitHub
parent 22ec1a4996 1a169c9dc5
commit 9ffe34757e
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/patches/v12_0/move_item_tax_to_item_tax_template.py
View File

@@ -113,6 +113,7 @@ def get_item_tax_template(
# if no item tax template found, create one # if no item tax template found, create one
item_tax_template = frappe.new_doc("Item Tax Template") item_tax_template = frappe.new_doc("Item Tax Template")
item_tax_template.title = make_autoname("Item Tax Template-.####") item_tax_template.title = make_autoname("Item Tax Template-.####")
item_tax_template_name = item_tax_template.title
for tax_type, tax_rate in iteritems(item_tax_map): for tax_type, tax_rate in iteritems(item_tax_map):
account_details = frappe.db.get_value( account_details = frappe.db.get_value(
@@ -120,6 +121,10 @@ def get_item_tax_template(
) )
if account_details: if account_details:
item_tax_template.company = account_details.company item_tax_template.company = account_details.company
if not item_tax_template_name:
# set name once company is set as name is generated from company & title
# setting name is required to update `item_tax_templates` dict
item_tax_template_name = item_tax_template.set_new_name()
if account_details.account_type not in ( if account_details.account_type not in (
"Tax", "Tax",
"Chargeable", "Chargeable",
@@ -179,8 +184,9 @@ def get_item_tax_template(
if tax_type not in tax_types: if tax_type not in tax_types:
item_tax_template.append("taxes", {"tax_type": tax_type, "tax_rate": tax_rate}) item_tax_template.append("taxes", {"tax_type": tax_type, "tax_rate": tax_rate})
tax_types.append(tax_type) tax_types.append(tax_type)
item_tax_templates.setdefault(item_tax_template.title, {}) item_tax_templates.setdefault(item_tax_template_name, {})
item_tax_templates[item_tax_template.title][tax_type] = tax_rate item_tax_templates[item_tax_template_name][tax_type] = tax_rate
if item_tax_template.get("taxes"): if item_tax_template.get("taxes"):
item_tax_template.save() item_tax_template.save()
return item_tax_template.name return item_tax_template.name