nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-16 18:24:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(stock): use db-agnostic index introspection in Item index test

Browse Source 
test_index_creation used `frappe.db.sql("show index from tabItem")` and the MySQL-only
result key "Column_name". "SHOW INDEX" errors on Postgres, so the test could not run
there. Use the db-agnostic frappe.db.get_column_index("tabItem", column) (checking both
unique and non-unique single-column indexes) instead.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mihir Kandoi
2026-06-21 10:25:32 +05:30
parent f66ef869fc
commit 9fe2202f39
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/stock/doctype/item/test_item.py
View File

@@ -778,10 +778,13 @@ class TestItem(ERPNextTestSuite):
def test_index_creation(self): def test_index_creation(self):
"check if index is getting created in db" "check if index is getting created in db"
indices = frappe.db.sql("show index from tabItem", as_dict=1) # get_column_index is db-agnostic; raw "SHOW INDEX" is MySQL-only and errors on Postgres
expected_columns = {"item_code", "item_name", "item_group"} expected_columns = {"item_code", "item_name", "item_group"}
for index in indices: for column in list(expected_columns):
expected_columns.discard(index.get("Column_name")) if frappe.db.get_column_index("tabItem", column, unique=False) or frappe.db.get_column_index(
"tabItem", column, unique=True
):
expected_columns.discard(column)
if expected_columns: if expected_columns:
self.fail(f"Expected db index on these columns: {', '.join(expected_columns)}") self.fail(f"Expected db index on these columns: {', '.join(expected_columns)}")