From 9d8cb2f57c91b653e2d09be7f5701b061b36ca28 Mon Sep 17 00:00:00 2001 From: khushi8112 Date: Tue, 5 Aug 2025 14:00:27 +0530 Subject: [PATCH] fix: submit depreciation schedule only for submitted asset (cherry picked from commit a4628c20241494cc0df8d6058b0d0ab9464408d6) # Conflicts: # erpnext/assets/doctype/asset_depreciation_schedule/asset_depreciation_schedule.py --- .../asset_depreciation_schedule.py | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/erpnext/assets/doctype/asset_depreciation_schedule/asset_depreciation_schedule.py b/erpnext/assets/doctype/asset_depreciation_schedule/asset_depreciation_schedule.py index f9c4913b1a2..bdbf7322757 100644 --- a/erpnext/assets/doctype/asset_depreciation_schedule/asset_depreciation_schedule.py +++ b/erpnext/assets/doctype/asset_depreciation_schedule/asset_depreciation_schedule.py @@ -98,9 +98,30 @@ class AssetDepreciationSchedule(Document): ) def on_submit(self): + self.validate_asset() self.db_set("status", "Active") +<<<<<<< HEAD def before_cancel(self): +======= + def validate_asset(self): + asset = frappe.get_doc("Asset", self.asset) + if not asset.calculate_depreciation: + frappe.throw( + _("Asset {0} is not set to calculate depreciation.").format( + get_link_to_form("Asset", self.asset) + ) + ) + if asset.docstatus != 1: + frappe.throw( + _("Asset {0} is not submitted. Please submit the asset before proceeding.").format( + get_link_to_form("Asset", self.asset) + ) + ) + + def on_cancel(self): + self.db_set("status", "Cancelled") +>>>>>>> a4628c2024 (fix: submit depreciation schedule only for submitted asset) if not self.flags.should_not_cancel_depreciation_entries: self.cancel_depreciation_entries()