From 9c353741adcd2ad9c96911894990cfd589b9626a Mon Sep 17 00:00:00 2001 From: Diptanil Saha Date: Mon, 13 Jul 2026 16:54:56 +0530 Subject: [PATCH] fix(tnc): using `get_cached_doc` to retrieve template for `get_terms_and_conditions` and permission checks (#57096) --- .../doctype/terms_and_conditions/terms_and_conditions.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/erpnext/setup/doctype/terms_and_conditions/terms_and_conditions.py b/erpnext/setup/doctype/terms_and_conditions/terms_and_conditions.py index 5a54f2e7714..23b3fef917b 100644 --- a/erpnext/setup/doctype/terms_and_conditions/terms_and_conditions.py +++ b/erpnext/setup/doctype/terms_and_conditions/terms_and_conditions.py @@ -39,7 +39,10 @@ class TermsandConditions(Document): def get_terms_and_conditions(template_name: str, doc: str | dict): doc = frappe.parse_json(doc) - terms = frappe.get_cached_value("Terms and Conditions", template_name, "terms") + tnc = frappe.get_cached_doc("Terms and Conditions", template_name) + tnc.check_permission() - if terms: - return frappe.render_template(terms, doc, restrict_globals=True) + if not tnc.terms: + return + + return frappe.render_template(tnc.terms, doc, restrict_globals=True)