nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-23 15:09:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #50535 from aerele/support-53360

Browse Source 
fix: construct batch_nos and serial_nos to avoid NoneType error
This commit is contained in:
rohitwaghchaure
2025-11-17 16:24:20 +05:30
committed by GitHub
parent eed144d7c9 2a5c9b469c
commit 9b06eaab78
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
erpnext/stock/doctype/stock_reconciliation/test_stock_reconciliation.py
View File

@@ -45,6 +45,7 @@ class TestStockReconciliation(FrappeTestCase, StockTestMixin):
def test_reco_for_moving_average(self): def test_reco_for_moving_average(self):
self._test_reco_sle_gle("Moving Average") self._test_reco_sle_gle("Moving Average")
@change_settings("Stock Settings", {"allow_negative_stock": 1})
def _test_reco_sle_gle(self, valuation_method): def _test_reco_sle_gle(self, valuation_method):
item_code = self.make_item(properties={"valuation_method": valuation_method}).name item_code = self.make_item(properties={"valuation_method": valuation_method}).name

2
erpnext/stock/stock_ledger.py
View File

@@ -2240,9 +2240,11 @@ def validate_reserved_stock(kwargs):
kwargs.ignore_voucher_nos = [kwargs.voucher_no] kwargs.ignore_voucher_nos = [kwargs.voucher_no]
if kwargs.serial_no: if kwargs.serial_no:
kwargs.serial_nos = kwargs.serial_no.split("\n")
validate_reserved_serial_nos(kwargs) validate_reserved_serial_nos(kwargs)
elif kwargs.batch_no: elif kwargs.batch_no:
kwargs.batch_nos = [kwargs.batch_no]
validate_reserved_batch_nos(kwargs) validate_reserved_batch_nos(kwargs)
elif kwargs.serial_and_batch_bundle: elif kwargs.serial_and_batch_bundle: