mirror of
https://github.com/frappe/erpnext.git
synced 2026-05-26 08:24:47 +00:00
refactor(Work Order): query_sales_order
- Use `get_list` instead of `db.sql_list`
The method is used for setting link options in the frontend and the Link field doesn't ignore permissions, so get_list should be fine here.
- Added type hints to enable argument validation
(cherry picked from commit 2dbdacf905)
This commit is contained in:
@@ -1322,20 +1322,20 @@ def stop_unstop(work_order, status):
|
|||||||
|
|
||||||
|
|
||||||
@frappe.whitelist()
|
@frappe.whitelist()
|
||||||
def query_sales_order(production_item):
|
def query_sales_order(production_item: str) -> list[str]:
|
||||||
out = frappe.db.sql_list(
|
return frappe.get_list(
|
||||||
"""
|
"Sales Order",
|
||||||
select distinct so.name from `tabSales Order` so, `tabSales Order Item` so_item
|
filters=[
|
||||||
where so_item.parent=so.name and so_item.item_code=%s and so.docstatus=1
|
["Sales Order", "docstatus", "=", 1],
|
||||||
union
|
],
|
||||||
select distinct so.name from `tabSales Order` so, `tabPacked Item` pi_item
|
or_filters=[
|
||||||
where pi_item.parent=so.name and pi_item.item_code=%s and so.docstatus=1
|
["Sales Order Item", "item_code", "=", production_item],
|
||||||
""",
|
["Packed Item", "item_code", "=", production_item],
|
||||||
(production_item, production_item),
|
],
|
||||||
|
pluck="name",
|
||||||
|
distinct=True,
|
||||||
)
|
)
|
||||||
|
|
||||||
return out
|
|
||||||
|
|
||||||
|
|
||||||
@frappe.whitelist()
|
@frappe.whitelist()
|
||||||
def make_job_card(work_order, operations):
|
def make_job_card(work_order, operations):
|
||||||
|
|||||||
Reference in New Issue
Block a user