fix: review fixes

This commit is contained in:
Anupam
2020-10-12 18:06:58 +05:30
parent 134b0fd18b
commit 984fdde692
2 changed files with 6 additions and 3 deletions

View File

@@ -1,4 +1,5 @@
{ {
"actions": [],
"allow_rename": 1, "allow_rename": 1,
"autoname": "format:PRC-{quality_procedure_name}", "autoname": "format:PRC-{quality_procedure_name}",
"creation": "2018-10-06 00:06:29.756804", "creation": "2018-10-06 00:06:29.756804",
@@ -17,7 +18,6 @@
], ],
"fields": [ "fields": [
{ {
"depends_on": "eval: doc.is_group == 0",
"fieldname": "parent_quality_procedure", "fieldname": "parent_quality_procedure",
"fieldtype": "Link", "fieldtype": "Link",
"label": "Parent Procedure", "label": "Parent Procedure",
@@ -71,7 +71,8 @@
} }
], ],
"is_tree": 1, "is_tree": 1,
"modified": "2020-09-22 12:56:50.700777", "links": [],
"modified": "2020-10-12 16:14:11.167537",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Quality Management", "module": "Quality Management",
"name": "Quality Procedure", "name": "Quality Procedure",

View File

@@ -4,7 +4,7 @@
from __future__ import unicode_literals from __future__ import unicode_literals
import frappe import frappe
from frappe.utils.nestedset import NestedSet from frappe.utils.nestedset import NestedSet, rebuild_tree
from frappe import _ from frappe import _
class QualityProcedure(NestedSet): class QualityProcedure(NestedSet):
@@ -42,6 +42,8 @@ class QualityProcedure(NestedSet):
doc.save(ignore_permissions=True) doc.save(ignore_permissions=True)
def set_parent(self): def set_parent(self):
rebuild_tree('Quality Procedure', 'parent_quality_procedure')
for process in self.processes: for process in self.processes:
# Set parent for only those children who don't have a parent # Set parent for only those children who don't have a parent
parent_quality_procedure = frappe.db.get_value("Quality Procedure", process.procedure, "parent_quality_procedure") parent_quality_procedure = frappe.db.get_value("Quality Procedure", process.procedure, "parent_quality_procedure")