nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-28 22:28:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(accounts): merge gl_entry_builder.py into base_gl_composer.py

Browse Source 
The free functions (get_gl_dict, add_gl_entry, get_voucher_subtype, etc.) live
in the same module as BaseGLComposer — they are all about building GL entries,
so there is no reason to split them across two files. Removes gl_entry_builder.py
and updates all import references to base_gl_composer.
This commit is contained in:
Nabin Hait
2026-05-27 22:32:06 +05:30
parent cba6a31497
commit 983d80f7c5
4 changed files with 225 additions and 236 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/controllers/accounts_controller.py
View File

@@ -19,6 +19,7 @@ from frappe.utils import (
comma_and,
flt,
fmt_money,
formatdate,
get_last_day,
get_link_to_form,
getdate,
@@ -50,6 +51,7 @@ from erpnext.accounts.utils import (
create_gain_loss_journal,
get_account_currency,
get_currency_precision,
get_fiscal_years,
validate_fiscal_year,
)
from erpnext.accounts.utils import (
@@ -1291,17 +1293,17 @@ class AccountsController(TransactionBase):
)
def get_gl_dict(self, args, account_currency=None, item=None):
from erpnext.accounts.services.gl_entry_builder import get_gl_dict
from erpnext.accounts.services.base_gl_composer import get_gl_dict
return get_gl_dict(self, args, account_currency, item)
def get_voucher_subtype(self):
from erpnext.accounts.services.gl_entry_builder import get_voucher_subtype
from erpnext.accounts.services.base_gl_composer import get_voucher_subtype
return get_voucher_subtype(self)
def get_value_in_transaction_currency(self, account_currency, gl_dict, field):
from erpnext.accounts.services.gl_entry_builder import get_value_in_transaction_currency
from erpnext.accounts.services.base_gl_composer import get_value_in_transaction_currency
return get_value_in_transaction_currency(self, account_currency, gl_dict, field)
@@ -1335,7 +1337,7 @@ class AccountsController(TransactionBase):
)
def validate_account_currency(self, account, account_currency=None):
from erpnext.accounts.services.gl_entry_builder import validate_account_currency
from erpnext.accounts.services.base_gl_composer import validate_account_currency
return validate_account_currency(self, account, account_currency)
@@ -3492,7 +3494,7 @@ def validate_einvoice_fields(doc):
pass
from erpnext.accounts.services.gl_entry_builder import (
from erpnext.accounts.services.base_gl_composer import (
update_gl_dict_with_app_based_fields,
update_gl_dict_with_regional_fields,
)