From 958cc6f8f854ca8ee70c219b80d60958fd393fde Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 4 Jun 2025 19:04:24 +0530 Subject: [PATCH] perf: use estimated count on item table --- erpnext/controllers/queries.py | 2 +- .../doctype/inventory_dimension/test_inventory_dimension.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/erpnext/controllers/queries.py b/erpnext/controllers/queries.py index 3f09c7dd5cc..c5d4b0b3418 100644 --- a/erpnext/controllers/queries.py +++ b/erpnext/controllers/queries.py @@ -236,7 +236,7 @@ def item_query(doctype, txt, searchfield, start, page_len, filters, as_dict=Fals filters.pop("supplier", None) description_cond = "" - if frappe.db.count(doctype, cache=True) < 50000: + if frappe.db.estimate_count(doctype) < 50000: # scan description only if items are less than 50000 description_cond = "or tabItem.description LIKE %(txt)s" diff --git a/erpnext/stock/doctype/inventory_dimension/test_inventory_dimension.py b/erpnext/stock/doctype/inventory_dimension/test_inventory_dimension.py index ad3f3d59436..f0aab97933d 100644 --- a/erpnext/stock/doctype/inventory_dimension/test_inventory_dimension.py +++ b/erpnext/stock/doctype/inventory_dimension/test_inventory_dimension.py @@ -160,7 +160,6 @@ class TestInventoryDimension(IntegrationTestCase): def test_inventory_dimension_for_purchase_receipt_and_delivery_note(self): frappe.clear_cache(doctype="Inventory Dimension") - frappe.clear_cache("Inventory Dimension") inv_dimension = create_inventory_dimension( reference_document="Rack", dimension_name="Rack", apply_to_all_doctypes=1