nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-20 07:22:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: BOM creator validation for parent row no (backport #41413) (#41558)

Browse Source 
fix: BOM creator validation for parent row no (#41413)

fix: bom creator valiation for parent row no
(cherry picked from commit ae3f5a38e1)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
This commit is contained in:
mergify[bot]
2024-05-20 19:42:54 +05:30
committed by GitHub
parent 0a36139ef4
commit 953de995bc
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/manufacturing/doctype/bom_creator/bom_creator.py
View File

@@ -80,6 +80,18 @@ class BOMCreator(Document):
if row.is_expandable and row.item_code == self.item_code: if row.is_expandable and row.item_code == self.item_code:
frappe.throw(_("Item {0} cannot be added as a sub-assembly of itself").format(row.item_code)) frappe.throw(_("Item {0} cannot be added as a sub-assembly of itself").format(row.item_code))
if not row.parent_row_no and row.fg_item and row.fg_item != self.item_code:
frappe.throw(
_("At row {0}: set Parent Row No for item {1}").format(row.idx, row.item_code),
title=_("Set Parent Row No in Items Table"),
)
elif row.parent_row_no and row.fg_item == self.item_code:
frappe.throw(
_("At row {0}: Parent Row No cannot be set for item {1}").format(row.idx, row.item_code),
title=_("Remove Parent Row No in Items Table"),
)
def set_status(self, save=False): def set_status(self, save=False):
self.status = { self.status = {
0: "Draft", 0: "Draft",
@@ -410,6 +422,10 @@ def add_sub_assembly(**kwargs):
parent_row_no = item_row.idx parent_row_no = item_row.idx
name = "" name = ""
else:
parent_row_no = [row.idx for row in doc.items if row.name == kwargs.fg_reference_id]
if parent_row_no:
parent_row_no = parent_row_no[0]
for row in bom_item.get("items"): for row in bom_item.get("items"):
row = frappe._dict(row) row = frappe._dict(row)