nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-31 18:59:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: improve code clarity per reviewer feedback

Browse Source 
- Rename stock_qty variable to reserved_qty for clarity
- Update get_pos_reserved_qty_from_table to return float
- Simplify aggregation logic in get_pos_reserved_qty
- Ensure return values match docstring specifications

(cherry picked from commit 54d3e5675f)
This commit is contained in:
Lewis
2025-08-13 16:25:58 -04:00
committed by Mergify
parent cc82836109
commit 93ad17ac7b
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/accounts/doctype/pos_invoice/pos_invoice.py
View File

@@ -813,8 +813,7 @@ def get_pos_reserved_qty(item_code, warehouse):
pinv_item_reserved_qty = get_pos_reserved_qty_from_table("POS Invoice Item", item_code, warehouse) pinv_item_reserved_qty = get_pos_reserved_qty_from_table("POS Invoice Item", item_code, warehouse)
packed_item_reserved_qty = get_pos_reserved_qty_from_table("Packed Item", item_code, warehouse) packed_item_reserved_qty = get_pos_reserved_qty_from_table("Packed Item", item_code, warehouse)
reserved_qty = flt(pinv_item_reserved_qty[0].stock_qty) if pinv_item_reserved_qty else 0 reserved_qty = pinv_item_reserved_qty + packed_item_reserved_qty
reserved_qty += flt(packed_item_reserved_qty[0].stock_qty) if packed_item_reserved_qty else 0
return reserved_qty return reserved_qty
@@ -839,7 +838,7 @@ def get_pos_reserved_qty_from_table(child_table, item_code, warehouse):
qty_column = "qty" if child_table == "Packed Item" else "stock_qty" qty_column = "qty" if child_table == "Packed Item" else "stock_qty"
stock_qty = ( reserved_qty = (
frappe.qb.from_(p_inv) frappe.qb.from_(p_inv)
.from_(p_item) .from_(p_item)
.select(Sum(p_item[qty_column]).as_("stock_qty")) .select(Sum(p_item[qty_column]).as_("stock_qty"))
@@ -852,7 +851,7 @@ def get_pos_reserved_qty_from_table(child_table, item_code, warehouse):
) )
).run(as_dict=True) ).run(as_dict=True)
return stock_qty return flt(reserved_qty[0].stock_qty) if reserved_qty else 0
@frappe.whitelist() @frappe.whitelist()