From 9391c8911cd76c17a07b43e8efdcdf7db12ed5b0 Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Wed, 10 Sep 2025 09:56:40 +0530 Subject: [PATCH] refactor: rename reactivity checkbox --- erpnext/public/js/controllers/transaction.js | 2 +- .../selling_settings/selling_settings.json | 16 ++++++++-------- .../doctype/selling_settings/selling_settings.py | 2 +- erpnext/startup/boot.py | 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/erpnext/public/js/controllers/transaction.js b/erpnext/public/js/controllers/transaction.js index c6d2c9a8248..92442a75226 100644 --- a/erpnext/public/js/controllers/transaction.js +++ b/erpnext/public/js/controllers/transaction.js @@ -592,7 +592,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe frappe.flags.dialog_set = false; // Experimental: This will be removed once stability is achieved. - if (frappe.boot.sysdefaults.use_server_side_reactivity) { + if (!frappe.boot.sysdefaults.use_legacy_js_reactivity) { var item = frappe.get_doc(cdt, cdn); frappe.call({ doc: doc, diff --git a/erpnext/selling/doctype/selling_settings/selling_settings.json b/erpnext/selling/doctype/selling_settings/selling_settings.json index 7b931f358c7..7d94cb6848e 100644 --- a/erpnext/selling/doctype/selling_settings/selling_settings.json +++ b/erpnext/selling/doctype/selling_settings/selling_settings.json @@ -38,7 +38,7 @@ "allow_zero_qty_in_quotation", "allow_zero_qty_in_sales_order", "experimental_section", - "use_server_side_reactivity" + "use_legacy_js_reactivity" ], "fields": [ { @@ -218,12 +218,6 @@ "fieldtype": "Section Break", "label": "Experimental" }, - { - "default": "1", - "fieldname": "use_server_side_reactivity", - "fieldtype": "Check", - "label": "Use Server Side Reactivity" - }, { "default": "0", "description": "Allows users to submit Sales Orders with zero quantity. Useful when rates are fixed but the quantities are not. Eg. Rate Contracts.", @@ -243,6 +237,12 @@ "fieldname": "fallback_to_default_price_list", "fieldtype": "Check", "label": "Use Prices from Default Price List as Fallback" + }, + { + "default": "0", + "fieldname": "use_legacy_js_reactivity", + "fieldtype": "Check", + "label": "Use Legacy (Client side) Reactivity" } ], "grid_page_length": 50, @@ -251,7 +251,7 @@ "index_web_pages_for_search": 1, "issingle": 1, "links": [], - "modified": "2025-09-23 21:10:14.826653", + "modified": "2025-09-24 16:08:48.865885", "modified_by": "Administrator", "module": "Selling", "name": "Selling Settings", diff --git a/erpnext/selling/doctype/selling_settings/selling_settings.py b/erpnext/selling/doctype/selling_settings/selling_settings.py index ebf18eb49d3..528e11f0d2d 100644 --- a/erpnext/selling/doctype/selling_settings/selling_settings.py +++ b/erpnext/selling/doctype/selling_settings/selling_settings.py @@ -44,7 +44,7 @@ class SellingSettings(Document): selling_price_list: DF.Link | None so_required: DF.Literal["No", "Yes"] territory: DF.Link | None - use_server_side_reactivity: DF.Check + use_legacy_js_reactivity: DF.Check validate_selling_price: DF.Check # end: auto-generated types diff --git a/erpnext/startup/boot.py b/erpnext/startup/boot.py index 8dccac80b88..d9d8a8f567c 100644 --- a/erpnext/startup/boot.py +++ b/erpnext/startup/boot.py @@ -17,8 +17,8 @@ def boot_session(bootinfo): bootinfo.sysdefaults.territory = frappe.get_single_value("Selling Settings", "territory") bootinfo.sysdefaults.customer_group = frappe.get_single_value("Selling Settings", "customer_group") - bootinfo.sysdefaults.use_server_side_reactivity = frappe.get_single_value( - "Selling Settings", "use_server_side_reactivity" + bootinfo.sysdefaults.use_legacy_js_reactivity = cint( + frappe.get_single_value("Selling Settings", "use_legacy_js_reactivity") ) bootinfo.sysdefaults.allow_stale = cint(frappe.get_single_value("Accounts Settings", "allow_stale")) bootinfo.sysdefaults.over_billing_allowance = frappe.get_single_value(