nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-28 14:18:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(bom): fetch routing operations when Routing is selected (#55813)

Browse Source 
fix(bom): fetch routing operations when routing is selected

frm.doc.operations is always an array in Frappe, so !frm.doc.operations
was always false (empty array [] is truthy in JS), causing get_routing()
to never fire when a Routing is selected on a BOM with no existing
operations.

Changed the guard to !frm.doc.operations.length so the fetch triggers
correctly when the operations table is empty.

Also wired the same fetch into the with_operations handler so that
enabling the checkbox after a Routing is already set will populate
operations without requiring the user to re-select the Routing.

Co-authored-by: Umair Sayed <umairsayed@Umairs-MacBook-Air-2.local>
This commit is contained in:
Mohammad Umair Sayed
2026-06-11 11:50:00 +05:30
committed by GitHub
parent 5a816d19cb
commit 9249fa89aa
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/manufacturing/doctype/bom/bom.js
View File

@@ -175,6 +175,9 @@ frappe.ui.form.on("BOM", {
with_operations: function (frm) { with_operations: function (frm) {
frm.set_df_property("fg_based_operating_cost", "hidden", frm.doc.with_operations ? 1 : 0); frm.set_df_property("fg_based_operating_cost", "hidden", frm.doc.with_operations ? 1 : 0);
frm.trigger("toggle_fields_for_semi_finished_goods"); frm.trigger("toggle_fields_for_semi_finished_goods");
if (frm.doc.routing && frm.doc.with_operations && !frm.doc.operations.length) {
frm.trigger("routing");
}
}, },
fg_based_operating_cost: function (frm) { fg_based_operating_cost: function (frm) {
@@ -583,7 +586,7 @@ frappe.ui.form.on("BOM", {
}, },
routing(frm) { routing(frm) {
if (frm.doc.routing && frm.doc.with_operations && !frm.doc.operations) { if (frm.doc.routing && frm.doc.with_operations && !frm.doc.operations.length) {
frappe.call({ frappe.call({
doc: frm.doc, doc: frm.doc,
method: "get_routing", method: "get_routing",