nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-03 20:29:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #42384 from frappe/mergify/bp/version-14-hotfix/pr-42374

Browse Source 
fix: Show the rows in AR/AP report where outstanding equals to 0.01 (backport #42374)
This commit is contained in:
ruthra kumar
2024-07-18 15:08:55 +05:30
committed by GitHub
parent 9fca232578 4fa9626de0
commit 92300b27c9
2 changed files with 33 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/accounts/report/accounts_receivable/accounts_receivable.py
View File

@@ -288,13 +288,13 @@ class ReceivablePayableReport:
must_consider = False must_consider = False
if self.filters.get("for_revaluation_journals"): if self.filters.get("for_revaluation_journals"):
if (abs(row.outstanding) > 0.0 / 10**self.currency_precision) or ( if (abs(row.outstanding) >= 0.0 / 10**self.currency_precision) or (
abs(row.outstanding_in_account_currency) > 0.0 / 10**self.currency_precision abs(row.outstanding_in_account_currency) >= 0.0 / 10**self.currency_precision
): ):
must_consider = True must_consider = True
else: else:
if (abs(row.outstanding) > 1.0 / 10**self.currency_precision) and ( if (abs(row.outstanding) >= 1.0 / 10**self.currency_precision) and (
(abs(row.outstanding_in_account_currency) > 1.0 / 10**self.currency_precision) (abs(row.outstanding_in_account_currency) >= 1.0 / 10**self.currency_precision)
or (row.voucher_no in self.err_journals) or (row.voucher_no in self.err_journals)
): ):
must_consider = True must_consider = True

29
erpnext/accounts/report/accounts_receivable/test_accounts_receivable.py
View File

@@ -955,3 +955,32 @@ class TestAccountsReceivable(AccountsTestMixin, FrappeTestCase):
self.assertEqual( self.assertEqual(
expected_data, [row.invoiced, row.outstanding, row.remaining_balance, row.future_amount] expected_data, [row.invoiced, row.outstanding, row.remaining_balance, row.future_amount]
) )
def test_accounts_receivable_output_for_minor_outstanding(self):
"""
AR/AP should report miniscule outstanding of 0.01. Or else there will be slight difference with General Ledger/Trial Balance
"""
filters = {
"company": self.company,
"report_date": today(),
"range1": 30,
"range2": 60,
"range3": 90,
"range4": 120,
}
# check invoice grand total and invoiced column's value for 3 payment terms
si = self.create_sales_invoice(no_payment_schedule=True)
pe = get_payment_entry("Sales Invoice", si.name, bank_account=self.cash, party_amount=99.99)
pe.paid_from = self.debit_to
pe.save().submit()
report = execute(filters)
expected_data_after_payment = [100, 100, 99.99, 0.01]
self.assertEqual(len(report[1]), 1)
row = report[1][0]
self.assertEqual(
expected_data_after_payment,
[row.invoice_grand_total, row.invoiced, row.paid, row.outstanding],
)