nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-02 19:59:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(Leave Balance Summary report): remove unused department approver queries

Browse Source
This commit is contained in:
Rucha Mahabal
2023-11-17 18:17:32 +05:30
parent 461eb7a50d
commit 9139c14639
1 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/hr/report/employee_leave_balance_summary/employee_leave_balance_summary.py
View File

@@ -6,9 +6,6 @@ import frappe
from frappe import _ from frappe import _
from erpnext.hr.doctype.leave_application.leave_application import get_leave_details from erpnext.hr.doctype.leave_application.leave_application import get_leave_details
from erpnext.hr.report.employee_leave_balance.employee_leave_balance import (
get_department_leave_approver_map,
)
def execute(filters=None): def execute(filters=None):
@@ -54,17 +51,11 @@ def get_data(filters, leave_types):
active_employees = frappe.get_all( active_employees = frappe.get_all(
"Employee", "Employee",
filters=conditions, filters=conditions,
fields=["name", "employee_name", "department", "user_id", "leave_approver"], fields=["name", "employee_name", "department", "user_id"],
) )
department_approver_map = get_department_leave_approver_map(filters.get("department"))
data = [] data = []
for employee in active_employees: for employee in active_employees:
leave_approvers = department_approver_map.get(employee.department_name, [])
if employee.leave_approver:
leave_approvers.append(employee.leave_approver)
row = [employee.name, employee.employee_name, employee.department] row = [employee.name, employee.employee_name, employee.department]
available_leave = get_leave_details(employee.name, filters.date) available_leave = get_leave_details(employee.name, filters.date)
for leave_type in leave_types: for leave_type in leave_types: