nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-24 05:47:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(assets): count complete opening depreciation periods accurately

Browse Source 
(cherry picked from commit 56f24a6adf)
This commit is contained in:
khushi8112
2026-09-23 11:48:32 +05:30
committed by Mergify
parent cfa5c25215
commit 900eb1e466
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
erpnext/assets/doctype/asset_depreciation_schedule/deppreciation_schedule_controller.py
View File

@@ -232,9 +232,17 @@ class DepreciationScheduleController(StraightLineMethod, WDVMethod):
last_depr_date = add_months(
self.fb_row.depreciation_start_date, -1 * self.fb_row.frequency_of_depreciation
)
if self.has_complete_opening_periods() and self.should_get_last_day:
last_depr_date = get_last_day(last_depr_date)
return last_depr_date
def get_booked_depr_for_months_count(self, last_depr_date):
if last_depr_date and self.has_complete_opening_periods():
first_period_end = self.get_next_schedule_date(
-cint(self.asset_doc.opening_number_of_booked_depreciations)
)
return month_diff(last_depr_date, first_period_end) - 1 + self.fb_row.frequency_of_depreciation
depr_booked_for_months = 0
if last_depr_date:
asset_used_for_months = self.fb_row.frequency_of_depreciation * (
@@ -250,6 +258,20 @@ class DepreciationScheduleController(StraightLineMethod, WDVMethod):
)
return depr_booked_for_months
def has_complete_opening_periods(self):
if (
self.fb_row.depreciation_method not in ("Straight Line", "Manual")
or self.fb_row.daily_prorata_based
or self.fb_row.shift_based
or not self.asset_doc.opening_number_of_booked_depreciations
):
return False
first_period_start = add_days(
self.get_next_schedule_date(-cint(self.asset_doc.opening_number_of_booked_depreciations) - 1), 1
)
return first_period_start == getdate(self.asset_doc.available_for_use_date)
def get_total_pending_days_or_years(self):
if cint(frappe.get_single_value("Accounts Settings", "calculate_depr_using_total_days")):
last_depr_date = self.get_last_booked_depreciation_date()