nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-29 09:54:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: fetch correct item tax template on item rate update (#47955)

Browse Source
This commit is contained in:
Diptanil Saha
2025-06-11 10:58:18 +05:30
committed by GitHub
parent a7974451fd
commit 8f4a6d248f
2 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
erpnext/public/js/controllers/transaction.js
View File

@@ -44,23 +44,22 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
if (item.item_code && item.rate) { if (item.item_code && item.rate) {
frappe.call({ frappe.call({
method: "frappe.client.get_value", method: "erpnext.stock.get_item_details.get_item_tax_template",
args: { args: {
doctype: "Item Tax", ctx: {
parent: "Item", item_code: item.item_code,
filters: { company: frm.doc.company,
parent: item.item_code, base_net_rate: item.base_net_rate,
minimum_net_rate: ["<=", item.rate], tax_category: frm.doc.tax_category,
maximum_net_rate: [">=", item.rate] item_tax_template: item.item_tax_template,
}, posting_date: frm.doc.posting_date,
fieldname: "item_tax_template" bill_date: frm.doc.bill_date,
transaction_date: frm.doc.transaction_date,
}
}, },
callback: function(r) { callback: function(r) {
const tax_rule = r.message; const item_tax_template = r.message;
frappe.model.set_value(cdt, cdn, 'item_tax_template', item_tax_template);
let matched_template = tax_rule ? tax_rule.item_tax_template : null;
frappe.model.set_value(cdt, cdn, 'item_tax_template', matched_template);
} }
}); });
} }

13
erpnext/stock/get_item_details.py
View File

@@ -672,8 +672,9 @@ def get_item_tax_info(doc, tax_category, item_codes, item_rates=None, item_tax_t
return out return out
@frappe.whitelist()
@erpnext.normalize_ctx_input(ItemDetailsCtx) @erpnext.normalize_ctx_input(ItemDetailsCtx)
def get_item_tax_template(ctx: ItemDetailsCtx, item, out: ItemDetails): def get_item_tax_template(ctx: ItemDetailsCtx, item=None, out: ItemDetails | None = None):
""" """
Determines item_tax template from item or parent item groups. Determines item_tax template from item or parent item groups.
@@ -691,6 +692,12 @@ def get_item_tax_template(ctx: ItemDetailsCtx, item, out: ItemDetails):
"base_net_rate": float "base_net_rate": float
} }
""" """
if not item:
if not ctx.get("item_code"):
frappe.throw(_("Item/Item Code required to get Item Tax Template."))
else:
item = frappe.get_cached_doc("Item", ctx.item_code)
item_tax_template = None item_tax_template = None
if item.taxes: if item.taxes:
item_tax_template = _get_item_tax_template(ctx, item.taxes, out) item_tax_template = _get_item_tax_template(ctx, item.taxes, out)
@@ -702,9 +709,11 @@ def get_item_tax_template(ctx: ItemDetailsCtx, item, out: ItemDetails):
item_tax_template = _get_item_tax_template(ctx, item_group_doc.taxes, out) item_tax_template = _get_item_tax_template(ctx, item_group_doc.taxes, out)
item_group = item_group_doc.parent_item_group item_group = item_group_doc.parent_item_group
if ctx.get("child_doctype") and item_tax_template: if out and ctx.get("child_doctype") and item_tax_template:
out.update(get_fetch_values(ctx.get("child_doctype"), "item_tax_template", item_tax_template)) out.update(get_fetch_values(ctx.get("child_doctype"), "item_tax_template", item_tax_template))
return item_tax_template
@erpnext.normalize_ctx_input(ItemDetailsCtx) @erpnext.normalize_ctx_input(ItemDetailsCtx)
def _get_item_tax_template( def _get_item_tax_template(