nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-04 12:49:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: speed up validate_account_for_perpetual_inventory (#26730)

Browse Source
This commit is contained in:
Ahmad
2021-08-09 11:47:11 +05:00
committed by GitHub
parent 09d5ddc42b
commit 8eca908365
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
erpnext/accounts/general_ledger.py
View File

@@ -147,7 +147,7 @@ def make_entry(args, adv_adj, update_outstanding, from_repost=False):
gle.submit() gle.submit()
def validate_account_for_perpetual_inventory(gl_map): def validate_account_for_perpetual_inventory(gl_map):
if cint(erpnext.is_perpetual_inventory_enabled(gl_map[0].company)): if cint(erpnext.is_perpetual_inventory_enabled(gl_map[0].company)) and gl_map[0].voucher_type=="Journal Entry":
account_list = [gl_entries.account for gl_entries in gl_map] account_list = [gl_entries.account for gl_entries in gl_map]
aii_accounts = [d.name for d in frappe.get_all("Account", aii_accounts = [d.name for d in frappe.get_all("Account",
@@ -160,13 +160,12 @@ def validate_account_for_perpetual_inventory(gl_map):
account_bal, stock_bal, warehouse_list = get_stock_and_account_balance(account, account_bal, stock_bal, warehouse_list = get_stock_and_account_balance(account,
gl_map[0].posting_date, gl_map[0].company) gl_map[0].posting_date, gl_map[0].company)
if gl_map[0].voucher_type=="Journal Entry": # In case of Journal Entry, there are no corresponding SL entries,
# In case of Journal Entry, there are no corresponding SL entries, # hence deducting currency amount
# hence deducting currency amount account_bal -= flt(gl_map[0].debit) - flt(gl_map[0].credit)
account_bal -= flt(gl_map[0].debit) - flt(gl_map[0].credit) if account_bal == stock_bal:
if account_bal == stock_bal: frappe.throw(_("Account: {0} can only be updated via Stock Transactions")
frappe.throw(_("Account: {0} can only be updated via Stock Transactions") .format(account), StockAccountInvalidTransaction)
.format(account), StockAccountInvalidTransaction)
# This has been comment for a temporary, will add this code again on release of immutable ledger # This has been comment for a temporary, will add this code again on release of immutable ledger
# elif account_bal != stock_bal: # elif account_bal != stock_bal: