From 8e23c6ad69dee213f0252d2b231317490fab760f Mon Sep 17 00:00:00 2001
From: Maharshi Patel <39730881+maharshivpatel@users.noreply.github.com>
Date: Wed, 20 Jul 2022 21:25:36 +0530
Subject: [PATCH] fix: assign duplicate_items_msg outside conditional (#31639)
duplicate_items_msg was defined inside if the statement of stock_item so when duplicate was found in non_stock_item it raised referenced before assignment
---
erpnext/controllers/selling_controller.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/erpnext/controllers/selling_controller.py b/erpnext/controllers/selling_controller.py
index b093e9ba388..8a26d9e2c89 100644
--- a/erpnext/controllers/selling_controller.py
+++ b/erpnext/controllers/selling_controller.py
@@ -614,13 +614,13 @@ class SellingController(StockController):
stock_items = [d.item_code, d.description, d.warehouse, ""]
non_stock_items = [d.item_code, d.description]
+ duplicate_items_msg = _("Item {0} entered multiple times.").format(frappe.bold(d.item_code))
+ duplicate_items_msg += "
"
+ duplicate_items_msg += _("Please enable {} in {} to allow same item in multiple rows").format(
+ frappe.bold("Allow Item to Be Added Multiple Times in a Transaction"),
+ get_link_to_form("Selling Settings", "Selling Settings"),
+ )
if frappe.db.get_value("Item", d.item_code, "is_stock_item") == 1:
- duplicate_items_msg = _("Item {0} entered multiple times.").format(frappe.bold(d.item_code))
- duplicate_items_msg += "
"
- duplicate_items_msg += _("Please enable {} in {} to allow same item in multiple rows").format(
- frappe.bold("Allow Item to Be Added Multiple Times in a Transaction"),
- get_link_to_form("Selling Settings", "Selling Settings"),
- )
if stock_items in check_list:
frappe.throw(duplicate_items_msg)
else: