nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-31 07:28:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: restore | dict + normalization on non-decorated helpers

Browse Source 
get_item_price is an internal, non-decorated helper: the "| dict" and
"pctx = frappe._dict(pctx)" were load-bearing (callers may pass a plain
dict; the body does attribute access). Restore both. Also restore the
"| dict" on set_valuation_rate/update_party_blanket_order out params
(these are not normalize_ctx_input-decorated).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
(cherry picked from commit f26cb793b1)

# Conflicts:
#	erpnext/stock/get_item_details.py
This commit is contained in:
Mihir Kandoi
2026-07-01 16:19:07 +05:30
committed by Mergify
parent eecce23372
commit 8d7348f40b
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/stock/get_item_details.py
View File

@@ -204,11 +204,15 @@ def remove_standard_fields(out: ItemDetailsCtx):
return out return out
<<<<<<< HEAD
<<<<<<< HEAD <<<<<<< HEAD
def get_rate_locked_source_row(ctx: ItemDetailsCtx, doc) -> frappe._dict | None: def get_rate_locked_source_row(ctx: ItemDetailsCtx, doc) -> frappe._dict | None:
"""Return the persisted source-document row a mapped target row is locked to. """Return the persisted source-document row a mapped target row is locked to.
======= =======
def set_valuation_rate(out: ItemDetailsCtx, ctx: ItemDetailsCtx): def set_valuation_rate(out: ItemDetailsCtx, ctx: ItemDetailsCtx):
=======
def set_valuation_rate(out: ItemDetailsCtx | dict, ctx: ItemDetailsCtx):
>>>>>>> f26cb793b1 (fix: restore | dict + normalization on non-decorated helpers)
from erpnext.selling.doctype.product_bundle.product_bundle import get_active_product_bundle from erpnext.selling.doctype.product_bundle.product_bundle import get_active_product_bundle
>>>>>>> 6eeadbdbef (fix: keep normalize_ctx_input's ctx annotation on Python 3.14) >>>>>>> 6eeadbdbef (fix: keep normalize_ctx_input's ctx annotation on Python 3.14)
@@ -1270,7 +1274,7 @@ def _get_stock_uom_rate(rate: float, ctx: ItemDetailsCtx):
def get_item_price( def get_item_price(
pctx: ItemDetailsCtx, item_code, ignore_party=False, force_batch_no=False pctx: ItemDetailsCtx | dict, item_code, ignore_party=False, force_batch_no=False
) -> list[dict]: ) -> list[dict]:
""" """
Get name, price_list_rate from Item Price based on conditions Get name, price_list_rate from Item Price based on conditions
@@ -1279,6 +1283,7 @@ def get_item_price(
optional fields transaction_date, customer, supplier optional fields transaction_date, customer, supplier
:param item_code: str, Item Doctype field item_code :param item_code: str, Item Doctype field item_code
""" """
pctx: ItemDetailsCtx = frappe._dict(pctx)
ip = frappe.qb.DocType("Item Price") ip = frappe.qb.DocType("Item Price")
query = ( query = (
@@ -1836,7 +1841,7 @@ def get_serial_no(_args, serial_nos=None, sales_order=None):
return serial_nos return serial_nos
def update_party_blanket_order(ctx: ItemDetailsCtx, out: ItemDetailsCtx): def update_party_blanket_order(ctx: ItemDetailsCtx, out: ItemDetailsCtx | dict):
if out["against_blanket_order"]: if out["against_blanket_order"]:
blanket_order_details = get_blanket_order_details(ctx) blanket_order_details = get_blanket_order_details(ctx)
if blanket_order_details: if blanket_order_details: