From 8ce63dac65137ea436c6402803858bf8a2560cef Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Wed, 17 Jun 2026 19:01:35 +0530 Subject: [PATCH] refactor(postgres): port Sales Taxes and Charges Template queries to the query builder Co-Authored-By: Claude Opus 4.8 (1M context) --- .../sales_taxes_and_charges_template.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/erpnext/accounts/doctype/sales_taxes_and_charges_template/sales_taxes_and_charges_template.py b/erpnext/accounts/doctype/sales_taxes_and_charges_template/sales_taxes_and_charges_template.py index 907b4cc6b19..bd39170cd82 100644 --- a/erpnext/accounts/doctype/sales_taxes_and_charges_template/sales_taxes_and_charges_template.py +++ b/erpnext/accounts/doctype/sales_taxes_and_charges_template/sales_taxes_and_charges_template.py @@ -56,11 +56,14 @@ def valdiate_taxes_and_charges_template(doc): # doc.is_default = 1 if doc.is_default == 1: - frappe.db.sql( - f"""update `tab{doc.doctype}` set is_default = 0 - where is_default = 1 and name != %s and company = %s""", - (doc.name, doc.company), - ) + template = frappe.qb.DocType(doc.doctype) + ( + frappe.qb.update(template) + .set(template.is_default, 0) + .where( + (template.is_default == 1) & (template.name != doc.name) & (template.company == doc.company) + ) + ).run() validate_disabled(doc)