nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-14 10:41:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: validate variant values (backport #54831) (#54839)

Browse Source 
fix: validate variant values (#54831)

(cherry picked from commit 95705f18aa)

Co-authored-by: Mihir Kandoi <kandoimihir@gmail.com>
This commit is contained in:
mergify[bot]
2026-05-11 21:23:34 +05:30
committed by GitHub
parent b894b02ebc
commit 87b798b936
2 changed files with 39 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/selling/doctype/sales_order/test_sales_order.py
View File

@@ -1619,7 +1619,7 @@ class TestSalesOrder(ERPNextTestSuite):
make_item( # template item make_item( # template item
"Test-WO-Tshirt", "Test-WO-Tshirt",
{ {
"has_variant": 1, "has_variants": 1,
"variant_based_on": "Item Attribute", "variant_based_on": "Item Attribute",
"attributes": [{"attribute": "Test Colour"}], "attributes": [{"attribute": "Test Colour"}],
}, },

38
erpnext/stock/doctype/item/item.py
View File

@@ -202,6 +202,7 @@ class Item(Document):
self.validate_warehouse_for_reorder() self.validate_warehouse_for_reorder()
self.update_bom_item_desc() self.update_bom_item_desc()
self.validate_variant()
self.validate_has_variants() self.validate_has_variants()
self.validate_attributes_in_variants() self.validate_attributes_in_variants()
self.validate_stock_exists_for_template_item() self.validate_stock_exists_for_template_item()
@@ -811,6 +812,43 @@ class Item(Document):
enqueue_after_commit=True, enqueue_after_commit=True,
) )
def validate_variant(self):
if self.variant_of:
has_variants, based_on = frappe.get_value(
"Item", self.variant_of, ["has_variants", "variant_based_on"]
)
if not has_variants:
frappe.throw(_("Item {0} is not a template item.").format(frappe.bold(self.variant_of)))
if based_on == "Item Attribute":
for d in self.attributes:
if not frappe.db.exists(
"Item Variant Attribute", {"attribute": d.attribute, "parent": self.variant_of}
):
frappe.throw(
_("Attribute {0} is not valid for the selected template.").format(
frappe.bold(d.attribute)
)
)
numeric_values, disabled = frappe.get_value(
"Item Variant Attribute",
{"attribute": d.attribute, "parent": self.variant_of},
["numeric_values", "disabled"],
)
if disabled:
frappe.throw(_("Attribute {0} is disabled.").format(frappe.bold(d.attribute)))
if not numeric_values and not frappe.db.exists(
"Item Attribute Value", {"parent": d.attribute, "attribute_value": d.attribute_value}
):
frappe.throw(
_("Attribute Value {0} is not valid for the selected attribute {1}.").format(
frappe.bold(d.attribute_value), frappe.bold(d.attribute)
)
)
def validate_has_variants(self): def validate_has_variants(self):
if self.is_new(): if self.is_new():
return return