From 82188757333a73bb9defeb8b31d51742f129806a Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Mon, 22 Jun 2026 07:49:57 +0530 Subject: [PATCH] refactor(subcontracting): fetch customer_warehouse only when needed In `validate_manufacture`, `customer_warehouse` is read only inside the `skip_transfer` branch but was fetched unconditionally, wasting a lookup on the non-skip-transfer path. Move it inside the branch that uses it. --- erpnext/controllers/subcontracting_inward_controller.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/controllers/subcontracting_inward_controller.py b/erpnext/controllers/subcontracting_inward_controller.py index ccc902b1d28..622a9d26eee 100644 --- a/erpnext/controllers/subcontracting_inward_controller.py +++ b/erpnext/controllers/subcontracting_inward_controller.py @@ -247,10 +247,10 @@ class SubcontractingInwardController: and frappe.get_cached_value("Item", item.item_code, "is_customer_provided_item") ] - customer_warehouse = frappe.get_cached_value( - "Subcontracting Inward Order", self.subcontracting_inward_order, "customer_warehouse" - ) if frappe.get_cached_value("Work Order", self.work_order, "skip_transfer"): + customer_warehouse = frappe.get_cached_value( + "Subcontracting Inward Order", self.subcontracting_inward_order, "customer_warehouse" + ) table = frappe.qb.DocType("Subcontracting Inward Order Received Item") query = ( frappe.qb.from_(table)