From 7f8fa7cf5e467bfa045ecc485930e65ee5d6cd72 Mon Sep 17 00:00:00 2001 From: Raffael Meyer <14891507+barredterra@users.noreply.github.com> Date: Wed, 22 Apr 2026 22:00:42 +0200 Subject: [PATCH] ci: test correctness pattern (#54186) --- semgrep/test-correctness.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/semgrep/test-correctness.yml b/semgrep/test-correctness.yml index 34eb82fa1d6..90a32af93e9 100644 --- a/semgrep/test-correctness.yml +++ b/semgrep/test-correctness.yml @@ -10,9 +10,15 @@ rules: languages: [python] severity: ERROR - id: Dont-override-teardown - pattern: | - def tearDown(...): - ... + patterns: + - pattern: | + def tearDown(...): + ... + - pattern-not: | + def tearDown(...): + ... + super().tearDown() + ... message: ERPNextTestSuite forces rollback on each tearDown, which ensures idempotency. Don't override tearDown. languages: [python] severity: ERROR