From 7f6e509e20be3dc4a9a7eb4ef5fd6eed66d7901d Mon Sep 17 00:00:00 2001 From: khushi8112 Date: Tue, 6 Jan 2026 01:25:56 +0530 Subject: [PATCH] refactor: more code cleanup --- .../budget_variance_report/budget_variance_report.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/erpnext/accounts/report/budget_variance_report/budget_variance_report.py b/erpnext/accounts/report/budget_variance_report/budget_variance_report.py index c93b9220f93..9fb7b12c4a5 100644 --- a/erpnext/accounts/report/budget_variance_report/budget_variance_report.py +++ b/erpnext/accounts/report/budget_variance_report/budget_variance_report.py @@ -19,7 +19,7 @@ def execute(filters=None): else: dimensions = get_budget_dimensions(filters) - budget_records = fetch_budget_accounts(filters, dimensions) + budget_records = get_budget_records(filters, dimensions) budget_map = build_budget_map(budget_records, filters) data = build_report_data(budget_map, filters) @@ -29,7 +29,7 @@ def execute(filters=None): return columns, data, None, chart_data -def fetch_budget_accounts(filters, dimensions): +def get_budget_records(filters, dimensions): budget_against_field = frappe.scrub(filters["budget_against"]) return frappe.db.sql( @@ -67,6 +67,11 @@ def fetch_budget_accounts(filters, dimensions): def build_budget_map(budget_records, filters): + """ + Builds a nested dictionary structure aggregating budget and actual amounts. + + Structure: {dimension_name: {account_name: {fiscal_year: {month_name: {"budget": amount, "actual": amount}}}}} + """ budget_map = {} for budget in budget_records: