nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-23 06:59:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use unbuffered cursor for fetching

Browse Source 
(cherry picked from commit 08903459c2)
This commit is contained in:
ruthra kumar
2025-04-27 11:12:55 +05:30
committed by Mergify
parent a4c9707fdf
commit 7c8245d299
1 changed files with 22 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
erpnext/accounts/report/accounts_receivable/accounts_receivable.py
View File

@@ -90,10 +90,7 @@ class ReceivablePayableReport:
self.skip_total_row = 1 self.skip_total_row = 1
def get_data(self): def get_data(self):
self.get_ple_entries()
self.get_sales_invoices_or_customers_based_on_sales_person() self.get_sales_invoices_or_customers_based_on_sales_person()
self.voucher_balance = OrderedDict()
self.init_voucher_balance() # invoiced, paid, credit_note, outstanding
# Build delivery note map against all sales invoices # Build delivery note map against all sales invoices
self.build_delivery_note_map() self.build_delivery_note_map()
@@ -110,7 +107,15 @@ class ReceivablePayableReport:
# Get Exchange Rate Revaluations # Get Exchange Rate Revaluations
self.get_exchange_rate_revaluations() self.get_exchange_rate_revaluations()
self.prepare_ple_query()
self.data = [] self.data = []
self.voucher_balance = OrderedDict()
self.ple_entries = []
with frappe.db.unbuffered_cursor():
for ple in frappe.db.sql(self.ple_query.get_sql(), as_dict=True, as_iterator=True):
self.init_voucher_balance(ple) # invoiced, paid, credit_note, outstanding
self.ple_entries.append(ple)
for ple in self.ple_entries: for ple in self.ple_entries:
self.update_voucher_balance(ple) self.update_voucher_balance(ple)
@@ -136,26 +141,22 @@ class ReceivablePayableReport:
outstanding_in_account_currency=0.0, outstanding_in_account_currency=0.0,
) )
def init_voucher_balance(self): def init_voucher_balance(self, ple):
# build all keys, since we want to exclude vouchers beyond the report date if self.filters.get("ignore_accounts"):
for ple in self.ple_entries: key = (ple.voucher_type, ple.voucher_no, ple.party)
# get the balance object for voucher_type else:
key = (ple.account, ple.voucher_type, ple.voucher_no, ple.party)
if self.filters.get("ignore_accounts"): if key not in self.voucher_balance:
key = (ple.voucher_type, ple.voucher_no, ple.party) self.voucher_balance[key] = self.build_voucher_dict(ple)
else:
key = (ple.account, ple.voucher_type, ple.voucher_no, ple.party)
if key not in self.voucher_balance: if ple.voucher_type == ple.against_voucher_type and ple.voucher_no == ple.against_voucher_no:
self.voucher_balance[key] = self.build_voucher_dict(ple) self.voucher_balance[key].cost_center = ple.cost_center
if ple.voucher_type == ple.against_voucher_type and ple.voucher_no == ple.against_voucher_no: self.get_invoices(ple)
self.voucher_balance[key].cost_center = ple.cost_center
self.get_invoices(ple) if self.filters.get("group_by_party"):
self.init_subtotal_row(ple.party)
if self.filters.get("group_by_party"):
self.init_subtotal_row(ple.party)
if self.filters.get("group_by_party") and not self.filters.get("in_party_currency"): if self.filters.get("group_by_party") and not self.filters.get("in_party_currency"):
self.init_subtotal_row("Total") self.init_subtotal_row("Total")
@@ -778,7 +779,7 @@ class ReceivablePayableReport:
) )
row["range" + str(index + 1)] = row.outstanding row["range" + str(index + 1)] = row.outstanding
def get_ple_entries(self): def prepare_ple_query(self):
# get all the GL entries filtered by the given filters # get all the GL entries filtered by the given filters
self.prepare_conditions() self.prepare_conditions()
@@ -831,7 +832,7 @@ class ReceivablePayableReport:
else: else:
query = query.orderby(self.ple.posting_date, self.ple.party) query = query.orderby(self.ple.posting_date, self.ple.party)
self.ple_entries = query.run(as_dict=True) self.ple_query = query
def get_sales_invoices_or_customers_based_on_sales_person(self): def get_sales_invoices_or_customers_based_on_sales_person(self):
if self.filters.get("sales_person"): if self.filters.get("sales_person"):