nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-25 16:04:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: depreciation amount not shown in asset register

Browse Source
This commit is contained in:
Saqib Ansari
2020-05-13 15:24:29 +05:30
committed by Nabin Hait
parent 37c3bd2892
commit 7c5e22e9d8
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
erpnext/assets/report/fixed_asset_register/fixed_asset_register.py
View File

@@ -27,10 +27,10 @@ def get_conditions(filters):
if filters.filter_based_on == "Fiscal Year": if filters.filter_based_on == "Fiscal Year":
fiscal_year = get_fiscal_year_data(filters.from_fiscal_year, filters.to_fiscal_year) fiscal_year = get_fiscal_year_data(filters.from_fiscal_year, filters.to_fiscal_year)
validate_fiscal_year(fiscal_year, filters.from_fiscal_year, filters.to_fiscal_year) validate_fiscal_year(fiscal_year, filters.from_fiscal_year, filters.to_fiscal_year)
year_start_date = getdate(fiscal_year.year_start_date) filters.year_start_date = getdate(fiscal_year.year_start_date)
year_end_date = getdate(fiscal_year.year_end_date) filters.year_end_date = getdate(fiscal_year.year_end_date)
conditions[date_field] = ["between", [year_start_date, year_end_date]] conditions[date_field] = ["between", [filters.year_start_date, filters.year_end_date]]
if filters.get('is_existing_asset'): if filters.get('is_existing_asset'):
conditions["is_existing_asset"] = filters.get('is_existing_asset') conditions["is_existing_asset"] = filters.get('is_existing_asset')
if filters.get('asset_category'): if filters.get('asset_category'):
@@ -51,12 +51,11 @@ def get_data(filters):
data = [] data = []
conditions = get_conditions(filters)
depreciation_amount_map = get_finance_book_value_map(filters) depreciation_amount_map = get_finance_book_value_map(filters)
pr_supplier_map = get_purchase_receipt_supplier_map() pr_supplier_map = get_purchase_receipt_supplier_map()
pi_supplier_map = get_purchase_invoice_supplier_map() pi_supplier_map = get_purchase_invoice_supplier_map()
conditions = get_conditions(filters)
group_by = frappe.scrub(filters.get("group_by")) group_by = frappe.scrub(filters.get("group_by"))
if group_by == "asset_category": if group_by == "asset_category":
@@ -86,7 +85,7 @@ def get_data(filters):
"vendor_name": pr_supplier_map.get(asset.purchase_receipt) or pi_supplier_map.get(asset.purchase_invoice), "vendor_name": pr_supplier_map.get(asset.purchase_receipt) or pi_supplier_map.get(asset.purchase_invoice),
"gross_purchase_amount": asset.gross_purchase_amount, "gross_purchase_amount": asset.gross_purchase_amount,
"opening_accumulated_depreciation": asset.opening_accumulated_depreciation, "opening_accumulated_depreciation": asset.opening_accumulated_depreciation,
"depreciated_amount": depreciation_amount_map.get(asset.name) or 0.0, "depreciated_amount": depreciation_amount_map.get(asset.asset_id) or 0.0,
"available_for_use_date": asset.available_for_use_date, "available_for_use_date": asset.available_for_use_date,
"location": asset.location, "location": asset.location,
"asset_category": asset.asset_category, "asset_category": asset.asset_category,
@@ -129,7 +128,7 @@ def prepare_chart_data(data, filters):
} }
def get_finance_book_value_map(filters): def get_finance_book_value_map(filters):
date = filters.get('purchase_date') or filters.get('available_for_use_date') or today() date = filters.to_date if filters.filter_based_on == "Date Range" else filters.year_end_date
return frappe._dict(frappe.db.sql(''' Select return frappe._dict(frappe.db.sql(''' Select
parent, SUM(depreciation_amount) parent, SUM(depreciation_amount)