From 7c57f5a304a3620be398e9be2f005d0fb1bba3bf Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Tue, 3 Jun 2025 18:32:27 +0530 Subject: [PATCH] feat: show warning toast if rate is 0 and allow zero valuation rate checkbox is not enabled --- erpnext/controllers/stock_controller.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/erpnext/controllers/stock_controller.py b/erpnext/controllers/stock_controller.py index 11d132963a4..a739956c837 100644 --- a/erpnext/controllers/stock_controller.py +++ b/erpnext/controllers/stock_controller.py @@ -64,6 +64,7 @@ class StockController(AccountsController): self.validate_internal_transfer() self.validate_putaway_capacity() self.reset_conversion_factor() + self.check_zero_rate() def reset_conversion_factor(self): for row in self.get("items"): @@ -79,6 +80,16 @@ class StockController(AccountsController): alert=True, ) + def check_zero_rate(self): + for item in self.get("items"): + if not item.get("base_rate") and not item.get("allow_zero_valuation_rate"): + frappe.toast( + _( + "Row #{0}: Item {1} has zero rate but 'Allow Zero Valuation Rate' is not enabled." + ).format(item.idx, frappe.bold(item.item_code)), + indicator="orange", + ) + def validate_items_exist(self): if not self.get("items"): return