fix: shipping rule applied twice on non stock items (#53655)

This commit is contained in:
Mihir Kandoi
2026-03-23 12:19:39 +05:30
committed by GitHub
parent 5154102468
commit 7a61d6fcd5
2 changed files with 13 additions and 1 deletions

View File

@@ -2290,6 +2290,16 @@ class AccountsController(TransactionBase):
return stock_items
def get_asset_items(self):
asset_items = []
item_codes = list(set(item.item_code for item in self.get("items")))
if item_codes:
asset_items = frappe.db.get_values(
"Item", {"name": ["in", item_codes], "is_fixed_asset": 1}, pluck="name", cache=True
)
return asset_items
def calculate_total_advance_from_ledger(self):
adv = frappe.qb.DocType("Advance Payment Ledger Entry")
return (