nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-01 00:34:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add permission check for get_item_details (backport #57515) (#57551)

Browse Source 
Co-authored-by: Diptanil Saha <diptanil@frappe.io>
This commit is contained in:
mergify[bot]
2026-07-28 14:47:51 +00:00
committed by GitHub
parent c690ed0058
commit 7a606ab91c
4 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/stock/doctype/item_default/item_default.json
View File

@@ -47,6 +47,7 @@
{
"fieldname": "default_warehouse",
"fieldtype": "Link",
"ignore_user_permissions": 1,
"in_list_view": 1,
"label": "Default Warehouse",
"options": "Warehouse",
@@ -75,6 +76,7 @@
"fieldname": "buying_cost_center",
"fieldtype": "Link",
"label": "Default Buying Cost Center",
"ignore_user_permissions": 1,
"options": "Cost Center",
"show_description_on_click": 1
},
@@ -94,6 +96,7 @@
"fieldname": "expense_account",
"fieldtype": "Link",
"label": "Default Expense Account",
"ignore_user_permissions": 1,
"options": "Account",
"show_description_on_click": 1
},
@@ -146,6 +149,7 @@
"fieldname": "deferred_expense_account",
"fieldtype": "Link",
"label": "Deferred Expense Account",
"ignore_user_permissions": 1,
"options": "Account",
"show_description_on_click": 1
},
@@ -183,6 +187,7 @@
"description": "Account to record additional purchase expenses like freight or customs for this item",
"fieldname": "purchase_expense_account",
"fieldtype": "Link",
"ignore_user_permissions": 1,
"label": "Purchase Expense Account",
"options": "Account",
"show_description_on_click": 1
@@ -191,6 +196,7 @@
"description": "Used to balance the books when recording extra purchase costs like freight or customs",
"fieldname": "purchase_expense_contra_account",
"fieldtype": "Link",
"ignore_user_permissions": 1,
"label": "Purchase Expense Contra Account",
"options": "Account"
},
@@ -198,6 +204,7 @@
"description": "Account to track value added to stock via Stock Entry, Stock Reconciliation or Landed Cost Voucher",
"fieldname": "expenses_added_to_stock_account",
"fieldtype": "Link",
"ignore_user_permissions": 1,
"label": "Expenses Added To Stock Account",
"options": "Account",
"show_description_on_click": 1
@@ -206,6 +213,7 @@
"description": "Used to balance the books when recording expenses added to stock",
"fieldname": "expenses_added_to_stock_contra_account",
"fieldtype": "Link",
"ignore_user_permissions": 1,
"label": "Expenses Added To Stock Contra Account",
"options": "Account",
"show_description_on_click": 1
@@ -215,6 +223,7 @@
"fieldname": "default_inventory_account",
"fieldtype": "Link",
"label": "Default Inventory Account",
"ignore_user_permissions": 1,
"options": "Account",
"show_description_on_click": 1
},
@@ -229,7 +238,7 @@
],
"istable": 1,
"links": [],
"modified": "2026-07-27 12:00:00.000000",
"modified": "2026-07-28 15:39:44.848087",
"modified_by": "Administrator",
"module": "Stock",
"name": "Item Default",

1
erpnext/stock/doctype/item_default/item_default.py
View File

@@ -35,6 +35,7 @@ class ItemDefault(Document):
parenttype: DF.Data
purchase_expense_account: DF.Link | None
purchase_expense_contra_account: DF.Link | None
purchase_price_variance_account: DF.Link | None
selling_cost_center: DF.Link | None
# end: auto-generated types

5
erpnext/stock/doctype/item_reorder/item_reorder.json
View File

@@ -1,5 +1,6 @@
{
"actions": [],
"allow_bulk_edit": 1,
"autoname": "hash",
"creation": "2013-03-07 11:42:59",
"doctype": "DocType",
@@ -18,6 +19,7 @@
"columns": 3,
"fieldname": "warehouse_group",
"fieldtype": "Link",
"ignore_user_permissions": 1,
"in_list_view": 1,
"label": "Check Availability in Warehouse",
"options": "Warehouse"
@@ -26,6 +28,7 @@
"columns": 2,
"fieldname": "warehouse",
"fieldtype": "Link",
"ignore_user_permissions": 1,
"in_list_view": 1,
"label": "Request for",
"options": "Warehouse",
@@ -59,7 +62,7 @@
"in_create": 1,
"istable": 1,
"links": [],
"modified": "2025-12-02 16:02:23.254963",
"modified": "2026-07-28 15:54:36.089238",
"modified_by": "Administrator",
"module": "Stock",
"name": "Item Reorder",

1
erpnext/stock/get_item_details.py
View File

@@ -84,6 +84,7 @@ def get_item_details(ctx, doc=None, for_validate=False, overwrite_warehouse=True
for_validate = parse_json(for_validate)
overwrite_warehouse = parse_json(overwrite_warehouse)
item = frappe.get_cached_doc("Item", ctx.item_code)
item.check_permission()
validate_item_details(ctx, item)
if isinstance(doc, str):