fix: review changes

This commit is contained in:
Anupam
2020-09-24 16:17:02 +05:30
parent a4df105813
commit 78ee75d744
2 changed files with 6 additions and 4 deletions

View File

@@ -96,7 +96,9 @@ def place_order():
def request_for_quotation(): def request_for_quotation():
quotation = _get_cart_quotation() quotation = _get_cart_quotation()
quotation.flags.ignore_permissions = True quotation.flags.ignore_permissions = True
quotation.save() if get_shopping_cart_settings().draft_quotation else quotation.submit() quotation.save()
if not get_shopping_cart_settings().draft_quotation:
quotation.submit()
return quotation.name return quotation.name
@frappe.whitelist() @frappe.whitelist()

View File

@@ -12,7 +12,6 @@
"show_price", "show_price",
"show_stock_availability", "show_stock_availability",
"enable_variants", "enable_variants",
"draft_quotation",
"column_break_7", "column_break_7",
"show_contact_us_button", "show_contact_us_button",
"show_quantity_in_website", "show_quantity_in_website",
@@ -28,6 +27,7 @@
"enable_checkout", "enable_checkout",
"payment_success_url", "payment_success_url",
"column_break_11", "column_break_11",
"draft_quotation",
"payment_gateway_account" "payment_gateway_account"
], ],
"fields": [ "fields": [
@@ -173,14 +173,14 @@
"depends_on": "eval: doc.enable_checkout == 0", "depends_on": "eval: doc.enable_checkout == 0",
"fieldname": "draft_quotation", "fieldname": "draft_quotation",
"fieldtype": "Check", "fieldtype": "Check",
"label": "Draft Quotation" "label": "Save Quotations as Draft"
} }
], ],
"icon": "fa fa-shopping-cart", "icon": "fa fa-shopping-cart",
"idx": 1, "idx": 1,
"issingle": 1, "issingle": 1,
"links": [], "links": [],
"modified": "2020-09-23 13:18:09.057707", "modified": "2020-09-24 16:07:04.862183",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Shopping Cart", "module": "Shopping Cart",
"name": "Shopping Cart Settings", "name": "Shopping Cart Settings",