From 782d16c1a337d5d650499c477f63c480387c0fee Mon Sep 17 00:00:00 2001 From: Khushi Rawat <142375893+khushi8112@users.noreply.github.com> Date: Tue, 25 Mar 2025 14:27:33 +0530 Subject: [PATCH] fix: linters related fix --- erpnext/assets/doctype/asset/asset.js | 2 +- erpnext/assets/doctype/asset_repair/asset_repair.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/erpnext/assets/doctype/asset/asset.js b/erpnext/assets/doctype/asset/asset.js index 2e7f8868dcb..94b45bc08e6 100644 --- a/erpnext/assets/doctype/asset/asset.js +++ b/erpnext/assets/doctype/asset/asset.js @@ -135,7 +135,7 @@ frappe.ui.form.on("Asset", { ); } - if (in_list(["Submitted", "Partially Depreciated"], frm.doc.status)) { + if (["Submitted", "Partially Depreciated"].includes(frm.doc.status)) { frm.add_custom_button( __("Adjust Asset Value"), function () { diff --git a/erpnext/assets/doctype/asset_repair/asset_repair.py b/erpnext/assets/doctype/asset_repair/asset_repair.py index 8a4349233e5..1d7d1791784 100644 --- a/erpnext/assets/doctype/asset_repair/asset_repair.py +++ b/erpnext/assets/doctype/asset_repair/asset_repair.py @@ -186,6 +186,7 @@ class AssetRepair(AccountsController): self.asset_doc.flags.ignore_validate_update_after_submit = True self.asset_doc.save() + self.asset_doc.db_update() def get_total_value_of_stock_consumed(self): return sum([flt(item.total_value) for item in self.get("stock_items")]) @@ -241,7 +242,7 @@ class AssetRepair(AccountsController): def make_gl_entries(self, cancel=False): if cancel: - self.ignore_linked_doctypes = ("GL Entry", "Stock Ledger Entry") + self.ignore_linked_doctypes = ("GL Entry", "Stock Ledger Entry") # nosemgrep if flt(self.total_repair_cost) > 0: gl_entries = self.get_gl_entries()