From 21217148567cc997d00b1bc1ffed312b21f04dc1 Mon Sep 17 00:00:00 2001 From: Saqib Ansari Date: Wed, 23 Nov 2022 21:33:04 +0530 Subject: [PATCH 1/2] fix: cannot update auth token until token expiry if credentials change --- .../doctype/e_invoice_settings/e_invoice_settings.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/erpnext/regional/doctype/e_invoice_settings/e_invoice_settings.py b/erpnext/regional/doctype/e_invoice_settings/e_invoice_settings.py index 897d8d86da4..0780795b24e 100644 --- a/erpnext/regional/doctype/e_invoice_settings/e_invoice_settings.py +++ b/erpnext/regional/doctype/e_invoice_settings/e_invoice_settings.py @@ -10,3 +10,8 @@ class EInvoiceSettings(Document): def validate(self): if self.enable and not self.credentials: frappe.throw(_("You must add atleast one credentials to be able to use E Invoicing.")) + + prev_doc = self.get_doc_before_save() + if prev_doc.client_secret != self.client_secret or prev_doc.client_id != prev_doc.client_id: + self.auth_token = None + self.token_expiry = None From b91860ddf23ba60bb0089a7dd4a12ca1adcb717e Mon Sep 17 00:00:00 2001 From: Saqib Ansari Date: Thu, 24 Nov 2022 15:26:32 +0530 Subject: [PATCH 2/2] fix: linter --- .../regional/doctype/e_invoice_settings/e_invoice_settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/regional/doctype/e_invoice_settings/e_invoice_settings.py b/erpnext/regional/doctype/e_invoice_settings/e_invoice_settings.py index 0780795b24e..3ce55c2622a 100644 --- a/erpnext/regional/doctype/e_invoice_settings/e_invoice_settings.py +++ b/erpnext/regional/doctype/e_invoice_settings/e_invoice_settings.py @@ -12,6 +12,6 @@ class EInvoiceSettings(Document): frappe.throw(_("You must add atleast one credentials to be able to use E Invoicing.")) prev_doc = self.get_doc_before_save() - if prev_doc.client_secret != self.client_secret or prev_doc.client_id != prev_doc.client_id: + if prev_doc.client_secret != self.client_secret or prev_doc.client_id != self.client_id: self.auth_token = None self.token_expiry = None