nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-21 07:38:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: multiple performance fixes in get_item_warehouse (backport #49118)

Browse Source 
Co-authored-by: Sagar Vora <16315650+sagarvora@users.noreply.github.com>
This commit is contained in:
mergify[bot]
2025-08-12 11:43:43 +00:00
committed by GitHub
parent 167ff00c99
commit 76b0f4fb25
4 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/setup/doctype/brand/brand.py
View File

@@ -35,7 +35,7 @@ def get_brand_defaults(item, company):
for d in brand.brand_defaults or []: for d in brand.brand_defaults or []:
if d.company == company: if d.company == company:
row = copy.deepcopy(d.as_dict()) row = d.as_dict(no_private_properties=True)
row.pop("name") row.pop("name")
return row return row

2
erpnext/setup/doctype/item_group/item_group.py
View File

@@ -90,7 +90,7 @@ def get_item_group_defaults(item, company):
for d in item_group.item_group_defaults or []: for d in item_group.item_group_defaults or []:
if d.company == company: if d.company == company:
row = copy.deepcopy(d.as_dict()) row = d.as_dict(no_private_properties=True)
row.pop("name") row.pop("name")
return row return row

2
erpnext/stock/doctype/item/item.py
View File

@@ -1281,7 +1281,7 @@ def get_item_defaults(item_code, company):
for d in item.item_defaults: for d in item.item_defaults:
if d.company == company: if d.company == company:
row = copy.deepcopy(d.as_dict()) row = d.as_dict(no_private_properties=True)
row.pop("name") row.pop("name")
out.update(row) out.update(row)
return out return out

15
erpnext/stock/get_item_details.py
View File

@@ -567,20 +567,15 @@ def get_item_warehouse(item, args, overwrite_warehouse, defaults=None):
or args.get("warehouse") or args.get("warehouse")
) )
if not warehouse:
defaults = frappe.defaults.get_defaults() or {}
warehouse_exists = frappe.db.exists(
"Warehouse", {"name": defaults.default_warehouse, "company": args.company}
)
if defaults.get("default_warehouse") and warehouse_exists:
warehouse = defaults.default_warehouse
else: else:
warehouse = args.get("warehouse") warehouse = args.get("warehouse")
if not warehouse: if not warehouse:
default_warehouse = frappe.db.get_single_value("Stock Settings", "default_warehouse") default_warehouse = frappe.get_single_value("Stock Settings", "default_warehouse")
if frappe.db.get_value("Warehouse", default_warehouse, "company") == args.company: if (
default_warehouse
and frappe.get_cached_value("Warehouse", default_warehouse, "company") == args.company
):
return default_warehouse return default_warehouse
return warehouse return warehouse