nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-16 11:39:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use float_precision while checking for negative stock in BIN

Browse Source
This commit is contained in:
Sagar Sharma
2023-05-26 04:15:27 +05:30
parent 82f0bd9ee9
commit 761f8a9f05
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/stock/doctype/stock_settings/stock_settings.py
View File

@@ -139,9 +139,15 @@ class StockSettings(Document):
else: else:
# Don't allow if there are negative stock # Don't allow if there are negative stock
has_negative_stock = frappe.db.exists("Bin", {"actual_qty": ["<", 0]}) from frappe.query_builder.functions import Round
if has_negative_stock: precision = frappe.db.get_single_value("System Settings", "float_precision") or 3
bin = frappe.qb.DocType("Bin")
bin_with_negative_stock = (
frappe.qb.from_(bin).select(bin.name).where(Round(bin.actual_qty, precision) < 0).limit(1)
).run()
if bin_with_negative_stock:
frappe.throw( frappe.throw(
_("As there are negative stock, you can not enable {0}.").format( _("As there are negative stock, you can not enable {0}.").format(
frappe.bold("Stock Reservation") frappe.bold("Stock Reservation")