fix: import issue and minor fixes

This commit is contained in:
Dany Robert
2021-12-10 10:27:15 +00:00
parent 614b9270e7
commit 75de5be53e
5 changed files with 23 additions and 15 deletions

View File

@@ -5,7 +5,10 @@ frappe.ui.form.on('Ledger Merge', {
setup: function(frm) { setup: function(frm) {
frappe.realtime.on('ledger_merge_refresh', ({ ledger_merge }) => { frappe.realtime.on('ledger_merge_refresh', ({ ledger_merge }) => {
if (ledger_merge !== frm.doc.name) return; if (ledger_merge !== frm.doc.name) return;
frm.refresh(); frappe.model.clear_doc(frm.doc.doctype, frm.doc.name);
frappe.model.with_doc(frm.doc.doctype, frm.doc.name).then(() => {
frm.refresh();
});
}); });
frappe.realtime.on('ledger_merge_progress', data => { frappe.realtime.on('ledger_merge_progress', data => {
@@ -25,30 +28,31 @@ frappe.ui.form.on('Ledger Merge', {
root_type: doc.root_type, root_type: doc.root_type,
company: doc.company company: doc.company
} }
} };
}); });
frm.set_query('account', 'merge_accounts', function(doc, cdt, cdn) { frm.set_query('account', 'merge_accounts', function(doc) {
if (!doc.company) frappe.throw(__('Please set Company')); if (!doc.company) frappe.throw(__('Please set Company'));
if (!doc.root_type) frappe.throw(__('Please set Root Type')); if (!doc.root_type) frappe.throw(__('Please set Root Type'));
if (!doc.account) frappe.throw(__('Please set Account')); if (!doc.account) frappe.throw(__('Please set Account'));
let acc = [doc.account];
frm.doc.merge_accounts.forEach((row) => {
acc.push(row.account);
});
return { return {
filters: { filters: {
is_group: 0, is_group: 0,
root_type: doc.root_type, root_type: doc.root_type,
name: ["!=", doc.account], name: ["not in", acc],
company: doc.company company: doc.company
} }
} };
}); });
}, },
refresh: function(frm) { refresh: function(frm) {
frm.page.hide_icon_group(); frm.page.hide_icon_group();
frm.trigger('set_merge_status'); frm.trigger('set_merge_status');
},
onload_post_render: function(frm) {
frm.trigger('update_primary_action'); frm.trigger('update_primary_action');
}, },
@@ -90,7 +94,7 @@ frappe.ui.form.on('Ledger Merge', {
if (frm.doc.status == "Pending") return; if (frm.doc.status == "Pending") return;
let successful_records = 0; let successful_records = 0;
frm.doc.merge_accounts.forEach((row) => { frm.doc.merge_accounts.forEach((row) => {
if(row.merged) successful_records += 1; if (row.merged) successful_records += 1;
}); });
let message_args = [successful_records, frm.doc.merge_accounts.length]; let message_args = [successful_records, frm.doc.merge_accounts.length];
frm.dashboard.set_headline(__('Successfully merged {0} out of {1}.', message_args)); frm.dashboard.set_headline(__('Successfully merged {0} out of {1}.', message_args));
@@ -108,15 +112,18 @@ frappe.ui.form.on('Ledger Merge', {
}); });
frappe.ui.form.on('Ledger Merge Accounts', { frappe.ui.form.on('Ledger Merge Accounts', {
merge_accounts_add: function(frm, cdt, cdn) { merge_accounts_add: function(frm) {
frm.trigger('update_primary_action'); frm.trigger('update_primary_action');
}, },
merge_accounts_remove: function(frm, cdt, cdn) { merge_accounts_remove: function(frm) {
frm.trigger('update_primary_action'); frm.trigger('update_primary_action');
}, },
account: function(frm, cdt, cdn) { account: function(frm, cdt, cdn) {
let row = frappe.get_doc(cdt, cdn);
row.account_name = row.account;
frm.refresh_field('merge_accounts');
frm.trigger('update_primary_action'); frm.trigger('update_primary_action');
} }
}); });

View File

@@ -21,7 +21,6 @@
"depends_on": "root_type", "depends_on": "root_type",
"fieldname": "account", "fieldname": "account",
"fieldtype": "Link", "fieldtype": "Link",
"in_list_view": 1,
"label": "Account", "label": "Account",
"options": "Account", "options": "Account",
"reqd": 1, "reqd": 1,
@@ -58,6 +57,7 @@
{ {
"fieldname": "status", "fieldname": "status",
"fieldtype": "Select", "fieldtype": "Select",
"in_list_view": 1,
"label": "Status", "label": "Status",
"options": "Pending\nSuccess\nPartial Success\nError", "options": "Pending\nSuccess\nPartial Success\nError",
"read_only": 1 "read_only": 1
@@ -83,7 +83,7 @@
], ],
"hide_toolbar": 1, "hide_toolbar": 1,
"links": [], "links": [],
"modified": "2021-12-09 23:41:11.097097", "modified": "2021-12-10 15:28:34.520588",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Accounts", "module": "Accounts",
"name": "Ledger Merge", "name": "Ledger Merge",

View File

@@ -2,6 +2,7 @@
# For license information, please see license.txt # For license information, please see license.txt
import frappe import frappe
from frappe import _
from frappe.model.document import Document from frappe.model.document import Document
from erpnext.accounts.doctype.account.account import merge_account from erpnext.accounts.doctype.account.account import merge_account

View File

@@ -4,5 +4,6 @@
# import frappe # import frappe
import unittest import unittest
class TestLedgerMerge(unittest.TestCase): class TestLedgerMerge(unittest.TestCase):
pass pass

View File

@@ -31,7 +31,6 @@
}, },
{ {
"columns": 4, "columns": 4,
"fetch_from": "account.account_name",
"fieldname": "account_name", "fieldname": "account_name",
"fieldtype": "Data", "fieldtype": "Data",
"label": "Account Name", "label": "Account Name",
@@ -42,7 +41,7 @@
"index_web_pages_for_search": 1, "index_web_pages_for_search": 1,
"istable": 1, "istable": 1,
"links": [], "links": [],
"modified": "2021-12-09 23:19:15.193921", "modified": "2021-12-10 15:27:24.477139",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Accounts", "module": "Accounts",
"name": "Ledger Merge Accounts", "name": "Ledger Merge Accounts",