From 75d00ef173c24d4230d20f8311325520277f90e4 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Mon, 1 Jun 2026 05:33:25 +0000 Subject: [PATCH] fix(stock): change qb to qb get_query to fix filter issues (backport #55443) (#55444) Co-authored-by: Sudharsanan Ashok <135326972+Sudharsanan11@users.noreply.github.com> fix(stock): change qb to qb get_query to fix filter issues (#55443) --- erpnext/controllers/queries.py | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/erpnext/controllers/queries.py b/erpnext/controllers/queries.py index b5bcadbdabc..3a5e7168034 100644 --- a/erpnext/controllers/queries.py +++ b/erpnext/controllers/queries.py @@ -370,10 +370,14 @@ def get_delivery_notes_to_be_billed( .where((DeliveryNote.docstatus == 1) & (DeliveryNote.is_return == 0) & (DeliveryNote.per_billed > 0)) ) + query = frappe.qb.get_query( + "Delivery Note", + fields=fields, + filters=filters, + ) + query = ( - frappe.qb.from_(DeliveryNote) - .select(*[DeliveryNote[f] for f in fields]) - .where( + query.where( (DeliveryNote.docstatus == 1) & (DeliveryNote.status.notin(["Stopped", "Closed"])) & (DeliveryNote[searchfield].like(f"%{txt}%")) @@ -387,12 +391,11 @@ def get_delivery_notes_to_be_billed( ) ) ) + .orderby(DeliveryNote[searchfield], order=Order.asc) + .limit(page_len) + .offset(start) ) - if filters and isinstance(filters, dict): - for key, value in filters.items(): - query = query.where(DeliveryNote[key] == value) - query = query.orderby(DeliveryNote[searchfield], order=Order.asc).limit(page_len).offset(start) return query.run(as_dict=as_dict)