nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-26 08:24:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: auto attendance marking for multiple shifts on the same day

Browse Source
This commit is contained in:
Rucha Mahabal
2022-02-22 17:30:28 +05:30
parent cb3b330097
commit 742c8f0790
2 changed files with 23 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/hr/doctype/employee_checkin/employee_checkin.py
View File

@@ -7,6 +7,7 @@ from frappe import _
from frappe.model.document import Document from frappe.model.document import Document
from frappe.utils import cint, get_datetime from frappe.utils import cint, get_datetime
from erpnext.hr.doctype.attendance.attendance import get_duplicate_attendance_record
from erpnext.hr.doctype.shift_assignment.shift_assignment import ( from erpnext.hr.doctype.shift_assignment.shift_assignment import (
get_actual_start_end_datetime_of_shift, get_actual_start_end_datetime_of_shift,
) )
@@ -124,12 +125,9 @@ def mark_attendance_and_link_log(
("1", log_names), ("1", log_names),
) )
return None return None
elif attendance_status in ("Present", "Absent", "Half Day"): elif attendance_status in ('Present', 'Absent', 'Half Day'):
employee_doc = frappe.get_doc("Employee", employee) employee_doc = frappe.get_doc('Employee', employee)
if not frappe.db.exists( if not get_duplicate_attendance_record(employee, attendance_date, shift):
"Attendance",
{"employee": employee, "attendance_date": attendance_date, "docstatus": ("!=", "2")},
):
doc_dict = { doc_dict = {
"doctype": "Attendance", "doctype": "Attendance",
"employee": employee, "employee": employee,

54
erpnext/hr/doctype/shift_type/shift_type.py
View File

@@ -30,48 +30,31 @@ class ShiftType(Document):
or not self.last_sync_of_checkin or not self.last_sync_of_checkin
): ):
return return
filters = { filters = {
"skip_auto_attendance": "0", 'skip_auto_attendance': 0,
"attendance": ("is", "not set"), 'attendance': ('is', 'not set'),
"time": (">=", self.process_attendance_after), 'time': ('>=', self.process_attendance_after),
"shift_actual_end": ("<", self.last_sync_of_checkin), 'shift_actual_end': ('<', self.last_sync_of_checkin),
"shift": self.name, 'shift': self.name
} }
logs = frappe.db.get_list( logs = frappe.db.get_list('Employee Checkin', fields="*", filters=filters, order_by="employee,time")
"Employee Checkin", fields="*", filters=filters, order_by="employee,time"
) for key, group in itertools.groupby(logs, key=lambda x: (x['employee'], x['shift_actual_start'])):
for key, group in itertools.groupby(
logs, key=lambda x: (x["employee"], x["shift_actual_start"])
):
single_shift_logs = list(group) single_shift_logs = list(group)
( attendance_status, working_hours, late_entry, early_exit, in_time, out_time = self.get_attendance(single_shift_logs)
attendance_status, mark_attendance_and_link_log(single_shift_logs, attendance_status, key[1].date(),
working_hours, working_hours, late_entry, early_exit, in_time, out_time, self.name)
late_entry,
early_exit,
in_time,
out_time,
) = self.get_attendance(single_shift_logs)
mark_attendance_and_link_log(
single_shift_logs,
attendance_status,
key[1].date(),
working_hours,
late_entry,
early_exit,
in_time,
out_time,
self.name,
)
for employee in self.get_assigned_employee(self.process_attendance_after, True): for employee in self.get_assigned_employee(self.process_attendance_after, True):
self.mark_absent_for_dates_with_no_attendance(employee) self.mark_absent_for_dates_with_no_attendance(employee)
def get_attendance(self, logs): def get_attendance(self, logs):
"""Return attendance_status, working_hours, late_entry, early_exit, in_time, out_time """Return attendance_status, working_hours, late_entry, early_exit, in_time, out_time
for a set of logs belonging to a single shift. for a set of logs belonging to a single shift.
Assumtion: Assumption:
1. These logs belongs to an single shift, single employee and is not in a holiday date. 1. These logs belongs to a single shift, single employee and it's not in a holiday date.
2. Logs are in chronological order 2. Logs are in chronological order
""" """
late_entry = early_exit = False late_entry = early_exit = False
total_working_hours, in_time, out_time = calculate_working_hours( total_working_hours, in_time, out_time = calculate_working_hours(
@@ -115,7 +98,7 @@ class ShiftType(Document):
start_date = max(getdate(self.process_attendance_after), date_of_joining) start_date = max(getdate(self.process_attendance_after), date_of_joining)
actual_shift_datetime = get_actual_start_end_datetime_of_shift(employee, get_datetime(self.last_sync_of_checkin), True) actual_shift_datetime = get_actual_start_end_datetime_of_shift(employee, get_datetime(self.last_sync_of_checkin), True)
last_shift_time = actual_shift_datetime.actual_start if actual_shift_datetime else get_datetime(self.last_sync_of_checkin) last_shift_time = actual_shift_datetime.actual_start if actual_shift_datetime else get_datetime(self.last_sync_of_checkin)
prev_shift = get_employee_shift(employee, last_shift_time.date()-timedelta(days=1), True, 'reverse') prev_shift = get_employee_shift(employee, last_shift_time - timedelta(days=1), True, 'reverse')
if prev_shift: if prev_shift:
end_date = ( end_date = (
min(prev_shift.start_datetime.date(), relieving_date) min(prev_shift.start_datetime.date(), relieving_date)
@@ -128,8 +111,9 @@ class ShiftType(Document):
if not holiday_list_name: if not holiday_list_name:
holiday_list_name = get_holiday_list_for_employee(employee, False) holiday_list_name = get_holiday_list_for_employee(employee, False)
dates = get_filtered_date_list(employee, start_date, end_date, holiday_list=holiday_list_name) dates = get_filtered_date_list(employee, start_date, end_date, holiday_list=holiday_list_name)
for date in dates: for date in dates:
shift_details = get_employee_shift(employee, date, True) shift_details = get_employee_shift(employee, get_datetime(date), True)
if shift_details and shift_details.shift_type.name == self.name: if shift_details and shift_details.shift_type.name == self.name:
mark_attendance(employee, date, "Absent", self.name) mark_attendance(employee, date, "Absent", self.name)