nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-30 18:34:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(maintenance): type annotations for whitelisted methods

Browse Source
This commit is contained in:
diptanilsaha
2026-02-27 16:00:20 +05:30
parent 048608556c
commit 73f72bda42
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
erpnext/maintenance/doctype/maintenance_schedule/maintenance_schedule.py
View File

@@ -405,9 +405,11 @@ class MaintenanceSchedule(TransactionBase):
delete_events(self.doctype, self.name) delete_events(self.doctype, self.name)
@frappe.whitelist() @frappe.whitelist()
def get_pending_data(self, data_type, s_date=None, item_name=None): def get_pending_data(self, data_type: str, s_date: str | None = None, item_name: str | None = None):
if data_type == "date": if data_type == "date":
dates = "" dates = ""
if not item_name:
frappe.throw(_("Item Name is required."))
for schedule in self.schedules: for schedule in self.schedules:
if schedule.item_name == item_name and schedule.completion_status == "Pending": if schedule.item_name == item_name and schedule.completion_status == "Pending":
dates = dates + "\n" + formatdate(schedule.scheduled_date, "dd-MM-yyyy") dates = dates + "\n" + formatdate(schedule.scheduled_date, "dd-MM-yyyy")
@@ -421,6 +423,8 @@ class MaintenanceSchedule(TransactionBase):
break break
return items return items
elif data_type == "id": elif data_type == "id":
if not s_date:
frappe.throw(_("Scheduled Date is required."))
for schedule in self.schedules: for schedule in self.schedules:
if schedule.item_name == item_name and s_date == formatdate( if schedule.item_name == item_name and s_date == formatdate(
schedule.scheduled_date, "dd-mm-yyyy" schedule.scheduled_date, "dd-mm-yyyy"
@@ -429,21 +433,23 @@ class MaintenanceSchedule(TransactionBase):
@frappe.whitelist() @frappe.whitelist()
def get_serial_nos_from_schedule(item_code, schedule=None): def get_serial_nos_from_schedule(item_code: str, schedule: str):
serial_nos = [] serial_nos = frappe.db.get_value(
if schedule: "Maintenance Schedule Item", {"parent": schedule, "item_code": item_code}, "serial_no"
serial_nos = frappe.db.get_value( )
"Maintenance Schedule Item", {"parent": schedule, "item_code": item_code}, "serial_no"
)
if serial_nos: serial_nos = get_serial_nos(serial_nos) if serial_nos else []
serial_nos = get_serial_nos(serial_nos)
return serial_nos return serial_nos
@frappe.whitelist() @frappe.whitelist()
def make_maintenance_visit(source_name, target_doc=None, item_name=None, s_id=None): def make_maintenance_visit(
source_name: str,
target_doc: str | dict | None = None,
item_name: str | None = None,
s_id: str | None = None,
):
from frappe.model.mapper import get_mapped_doc from frappe.model.mapper import get_mapped_doc
def condition(doc): def condition(doc):