nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-26 00:14:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #46171 from JK-1117/fix-reconciliation-inventory-dimension

Browse Source 
Fix validation mismatch in inventory dimension fields
This commit is contained in:
rohitwaghchaure
2025-04-08 14:26:25 +05:30
committed by GitHub
parent ea8ab256ad daa5bebdd0
commit 72846dc64f
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
erpnext/stock/doctype/inventory_dimension/inventory_dimension.py
View File

@@ -397,6 +397,7 @@ def get_inventory_dimensions():
"Inventory Dimension", "Inventory Dimension",
fields=[ fields=[
"distinct target_fieldname as fieldname", "distinct target_fieldname as fieldname",
"source_fieldname",
"reference_document as doctype", "reference_document as doctype",
"validate_negative_stock", "validate_negative_stock",
"name as dimension_name", "name as dimension_name",

2
erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py
View File

@@ -92,7 +92,7 @@ class StockReconciliation(StockController):
dimensions = get_inventory_dimensions() dimensions = get_inventory_dimensions()
for dimension in dimensions: for dimension in dimensions:
for row in self.items: for row in self.items:
if not row.batch_no and row.current_qty and row.get(dimension.get("fieldname")): if not row.batch_no and row.current_qty and row.get(dimension.get("source_fieldname")):
frappe.throw( frappe.throw(
_( _(
"Row #{0}: You cannot use the inventory dimension '{1}' in Stock Reconciliation to modify the quantity or valuation rate. Stock reconciliation with inventory dimensions is intended solely for performing opening entries." "Row #{0}: You cannot use the inventory dimension '{1}' in Stock Reconciliation to modify the quantity or valuation rate. Stock reconciliation with inventory dimensions is intended solely for performing opening entries."